Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: runtime/vm/flow_graph_compiler.cc

Issue 294223003: Last cross-platform cleanup in preparation of improved ARM code for indexed (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler.h ('k') | runtime/vm/flow_graph_compiler_arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler.cc
===================================================================
--- runtime/vm/flow_graph_compiler.cc (revision 36576)
+++ runtime/vm/flow_graph_compiler.cc (working copy)
@@ -1289,50 +1289,6 @@
}
-intptr_t FlowGraphCompiler::ElementSizeFor(intptr_t cid) {
- if (RawObject::IsExternalTypedDataClassId(cid)) {
- return ExternalTypedData::ElementSizeInBytes(cid);
- } else if (RawObject::IsTypedDataClassId(cid)) {
- return TypedData::ElementSizeInBytes(cid);
- }
- switch (cid) {
- case kArrayCid:
- case kImmutableArrayCid:
- return Array::kBytesPerElement;
- case kOneByteStringCid:
- return OneByteString::kBytesPerElement;
- case kTwoByteStringCid:
- return TwoByteString::kBytesPerElement;
- default:
- UNIMPLEMENTED();
- return 0;
- }
-}
-
-
-intptr_t FlowGraphCompiler::DataOffsetFor(intptr_t cid) {
- if (RawObject::IsExternalTypedDataClassId(cid)) {
- // Elements start at offset 0 of the external data.
- return 0;
- }
- if (RawObject::IsTypedDataClassId(cid)) {
- return TypedData::data_offset();
- }
- switch (cid) {
- case kArrayCid:
- case kImmutableArrayCid:
- return Array::data_offset();
- case kOneByteStringCid:
- return OneByteString::data_offset();
- case kTwoByteStringCid:
- return TwoByteString::data_offset();
- default:
- UNIMPLEMENTED();
- return Array::data_offset();
- }
-}
-
-
static int HighestCountFirst(const CidTarget* a, const CidTarget* b) {
// Negative if 'a' should sort before 'b'.
return b->count - a->count;
« no previous file with comments | « runtime/vm/flow_graph_compiler.h ('k') | runtime/vm/flow_graph_compiler_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698