Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: runtime/vm/object.cc

Issue 294223003: Last cross-platform cleanup in preparation of improved ARM code for indexed (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.cc
===================================================================
--- runtime/vm/object.cc (revision 36576)
+++ runtime/vm/object.cc (working copy)
@@ -13054,6 +13054,50 @@
}
+intptr_t Instance::ElementSizeFor(intptr_t cid) {
+ if (RawObject::IsExternalTypedDataClassId(cid)) {
+ return ExternalTypedData::ElementSizeInBytes(cid);
+ } else if (RawObject::IsTypedDataClassId(cid)) {
+ return TypedData::ElementSizeInBytes(cid);
+ }
+ switch (cid) {
+ case kArrayCid:
+ case kImmutableArrayCid:
+ return Array::kBytesPerElement;
+ case kOneByteStringCid:
+ return OneByteString::kBytesPerElement;
+ case kTwoByteStringCid:
+ return TwoByteString::kBytesPerElement;
+ default:
+ UNIMPLEMENTED();
+ return 0;
+ }
+}
+
+
+intptr_t Instance::DataOffsetFor(intptr_t cid) {
+ if (RawObject::IsExternalTypedDataClassId(cid)) {
+ // Elements start at offset 0 of the external data.
+ return 0;
+ }
+ if (RawObject::IsTypedDataClassId(cid)) {
+ return TypedData::data_offset();
+ }
+ switch (cid) {
+ case kArrayCid:
+ case kImmutableArrayCid:
+ return Array::data_offset();
+ case kOneByteStringCid:
+ return OneByteString::data_offset();
+ case kTwoByteStringCid:
+ return TwoByteString::data_offset();
+ default:
+ UNIMPLEMENTED();
+ return Array::data_offset();
+ }
+}
+
+
const char* Instance::ToCString() const {
if (IsNull()) {
return "null";
« no previous file with comments | « runtime/vm/object.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698