Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1363993004: Report info messages together with their error, warning, or hint. (Closed)

Created:
5 years, 3 months ago by Johnni Winther
Modified:
5 years, 3 months ago
Reviewers:
karlklose, sigurdm
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Report info messages together with their error, warning, or hint. BUG= R=sigurdm@google.com Committed: https://github.com/dart-lang/sdk/commit/1590970ccc03989923629ad590fd850dd7d85e6d

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased #

Patch Set 3 : Updated cf. comments. #

Total comments: 2

Patch Set 4 : Updated cf. comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1310 lines, -841 lines) Patch
M pkg/compiler/lib/src/apiimpl.dart View 1 2 10 chunks +37 lines, -21 lines 0 comments Download
M pkg/compiler/lib/src/compile_time_constants.dart View 1 2 10 chunks +47 lines, -47 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 2 12 chunks +76 lines, -56 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend.dart View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/outputter.dart View 1 chunk +12 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/diagnostic_listener.dart View 1 2 2 chunks +47 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 2 9 chunks +63 lines, -32 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 2 8 chunks +15 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_backend.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/no_such_method_registry.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/patch_resolver.dart View 1 2 8 chunks +35 lines, -23 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/library_loader.dart View 1 2 10 chunks +43 lines, -27 lines 0 comments Download
M pkg/compiler/lib/src/mirrors_used.dart View 1 2 4 chunks +9 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/native/behavior.dart View 1 2 4 chunks +11 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/ordered_typeset.dart View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/parser/element_listener.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/parser/member_listener.dart View 1 2 2 chunks +8 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/parser/node_listener.dart View 1 2 2 chunks +10 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/parser/partial_elements.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/patch_parser.dart View 1 2 9 chunks +81 lines, -37 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_hierarchy.dart View 1 2 11 chunks +63 lines, -32 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_members.dart View 1 2 10 chunks +74 lines, -39 lines 0 comments Download
M pkg/compiler/lib/src/resolution/constructors.dart View 1 2 16 chunks +54 lines, -36 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 2 56 chunks +190 lines, -116 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 2 24 chunks +80 lines, -51 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_common.dart View 1 2 5 chunks +15 lines, -19 lines 0 comments Download
M pkg/compiler/lib/src/resolution/signatures.dart View 1 2 13 chunks +30 lines, -23 lines 0 comments Download
M pkg/compiler/lib/src/resolution/type_resolver.dart View 1 2 7 chunks +27 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/resolution/typedefs.dart View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/variables.dart View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 2 15 chunks +20 lines, -17 lines 0 comments Download
M pkg/compiler/lib/src/string_validator.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 1 2 10 chunks +107 lines, -94 lines 0 comments Download
M tests/compiler/dart2js/analyze_unused_dart2js_test.dart View 1 chunk +9 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/compiler_test.dart View 2 chunks +11 lines, -13 lines 0 comments Download
M tests/compiler/dart2js/exit_code_test.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/js_spec_string_test.dart View 1 2 1 chunk +12 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 chunk +30 lines, -26 lines 0 comments Download
M tests/compiler/dart2js/parser_helper.dart View 1 2 2 chunks +25 lines, -16 lines 0 comments Download
M tests/compiler/dart2js/parser_test.dart View 1 2 1 chunk +14 lines, -9 lines 0 comments Download
M tests/compiler/dart2js/related_types.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/unparser2_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Johnni Winther
Main changes in compiler.dart and diagnostic_listener.dart
5 years, 3 months ago (2015-09-23 17:41:38 UTC) #2
Johnni Winther
5 years, 3 months ago (2015-09-24 09:05:22 UTC) #4
sigurdm
https://codereview.chromium.org/1363993004/diff/1/pkg/compiler/lib/src/diagnostics/diagnostic_listener.dart File pkg/compiler/lib/src/diagnostics/diagnostic_listener.dart (right): https://codereview.chromium.org/1363993004/diff/1/pkg/compiler/lib/src/diagnostics/diagnostic_listener.dart#newcode24 pkg/compiler/lib/src/diagnostics/diagnostic_listener.dart:24: void reportError( Perhaps define additional convenience methods: reportErrorMessage(Spannable node, ...
5 years, 3 months ago (2015-09-24 10:20:51 UTC) #5
Johnni Winther
PTAL https://codereview.chromium.org/1363993004/diff/1/pkg/compiler/lib/src/diagnostics/diagnostic_listener.dart File pkg/compiler/lib/src/diagnostics/diagnostic_listener.dart (right): https://codereview.chromium.org/1363993004/diff/1/pkg/compiler/lib/src/diagnostics/diagnostic_listener.dart#newcode24 pkg/compiler/lib/src/diagnostics/diagnostic_listener.dart:24: void reportError( On 2015/09/24 10:20:51, sigurdm wrote: > ...
5 years, 3 months ago (2015-09-24 12:08:38 UTC) #6
sigurdm
LGTM https://codereview.chromium.org/1363993004/diff/40001/pkg/compiler/lib/src/elements/elements.dart File pkg/compiler/lib/src/elements/elements.dart (right): https://codereview.chromium.org/1363993004/diff/40001/pkg/compiler/lib/src/elements/elements.dart#newcode822 pkg/compiler/lib/src/elements/elements.dart:822: /// Compute the info message associated with an ...
5 years, 3 months ago (2015-09-24 12:51:21 UTC) #7
Johnni Winther
Thanks, Sigurd! https://codereview.chromium.org/1363993004/diff/40001/pkg/compiler/lib/src/elements/elements.dart File pkg/compiler/lib/src/elements/elements.dart (right): https://codereview.chromium.org/1363993004/diff/40001/pkg/compiler/lib/src/elements/elements.dart#newcode822 pkg/compiler/lib/src/elements/elements.dart:822: /// Compute the info message associated with ...
5 years, 3 months ago (2015-09-24 13:00:51 UTC) #8
Johnni Winther
5 years, 3 months ago (2015-09-24 13:08:38 UTC) #9
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
1590970ccc03989923629ad590fd850dd7d85e6d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698