Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: tests/compiler/dart2js/analyze_unused_dart2js_test.dart

Issue 1363993004: Report info messages together with their error, warning, or hint. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated cf. comment. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/typechecker.dart ('k') | tests/compiler/dart2js/compiler_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/analyze_unused_dart2js_test.dart
diff --git a/tests/compiler/dart2js/analyze_unused_dart2js_test.dart b/tests/compiler/dart2js/analyze_unused_dart2js_test.dart
index 10fc5a594476a96a9f3536a2cc6b00fa81a65cf4..8f9e96729a299ff83c580e281ec025acd7937b62 100644
--- a/tests/compiler/dart2js/analyze_unused_dart2js_test.dart
+++ b/tests/compiler/dart2js/analyze_unused_dart2js_test.dart
@@ -81,20 +81,23 @@ bool checkResults(Compiler compiler, CollectingDiagnosticHandler handler) {
void checkLive(member) {
if (member.isFunction) {
if (compiler.enqueuer.resolution.hasBeenResolved(member)) {
- compiler.reportHint(member, MessageKind.GENERIC,
- {'text': "Helper function in production code '$member'."});
+ compiler.reportHint(compiler.createMessage(
+ member, MessageKind.GENERIC,
+ {'text': "Helper function in production code '$member'."}));
}
} else if (member.isClass) {
if (member.isResolved) {
- compiler.reportHint(member, MessageKind.GENERIC,
- {'text': "Helper class in production code '$member'."});
+ compiler.reportHint(compiler.createMessage(
+ member, MessageKind.GENERIC,
+ {'text': "Helper class in production code '$member'."}));
} else {
member.forEachLocalMember(checkLive);
}
} else if (member.isTypedef) {
if (member.isResolved) {
- compiler.reportHint(member, MessageKind.GENERIC,
- {'text': "Helper typedef in production code '$member'."});
+ compiler.reportHint(compiler.createMessage(
+ member, MessageKind.GENERIC,
+ {'text': "Helper typedef in production code '$member'."}));
}
}
}
« no previous file with comments | « pkg/compiler/lib/src/typechecker.dart ('k') | tests/compiler/dart2js/compiler_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698