pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart - Issue 1363993004: Report info messages together with their error, warning, or hint.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart

Issue 1363993004: Report info messages together with their error, warning, or hint. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Updated cf. comment. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_backend/patch_resolver.dart ('k') | pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart

diff --git a/pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart b/pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart

index d6748b9679d49a9e5e60ffa4f95cf479208ff4fc..c71eaa2dc00247df3dbb8c02e35303b9b275cca0 100644

--- a/pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart

+++ b/pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart

@@ -1812,7 +1812,8 @@ function(originalDescriptor, name, holder, isStatic, globalFunctionsAccess) {

if (backend.requiresPreamble &&

!backend.htmlLibraryIsLoaded) {

- compiler.reportHint(NO_LOCATION_SPANNABLE, MessageKind.PREAMBLE);

+ compiler.reportHintMessage(

+ NO_LOCATION_SPANNABLE, MessageKind.PREAMBLE);

}

// Return the total program size.

return outputBuffers.values.fold(0, (a, b) => a + b.length);