Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Unified Diff: pkg/compiler/lib/src/resolution/typedefs.dart

Issue 1363993004: Report info messages together with their error, warning, or hint. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated cf. comment. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/resolution/type_resolver.dart ('k') | pkg/compiler/lib/src/resolution/variables.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/resolution/typedefs.dart
diff --git a/pkg/compiler/lib/src/resolution/typedefs.dart b/pkg/compiler/lib/src/resolution/typedefs.dart
index f0939cb4f7a7f094392bd6714ebb462dec32da82..b86593c43ca90603c3187d8b2be82bd1a6cade93 100644
--- a/pkg/compiler/lib/src/resolution/typedefs.dart
+++ b/pkg/compiler/lib/src/resolution/typedefs.dart
@@ -89,12 +89,14 @@ class TypedefCyclicVisitor extends BaseDartTypeVisitor {
hasCyclicReference = true;
if (seenTypedefsCount == 1) {
// Direct cyclicity.
- compiler.reportError(element,
+ compiler.reportErrorMessage(
+ element,
MessageKind.CYCLIC_TYPEDEF,
{'typedefName': element.name});
} else if (seenTypedefsCount == 2) {
// Cyclicity through one other typedef.
- compiler.reportError(element,
+ compiler.reportErrorMessage(
+ element,
MessageKind.CYCLIC_TYPEDEF_ONE,
{'typedefName': element.name,
'otherTypedefName': seenTypedefs.head.name});
@@ -102,7 +104,8 @@ class TypedefCyclicVisitor extends BaseDartTypeVisitor {
// Cyclicity through more than one other typedef.
for (TypedefElement cycle in seenTypedefs) {
if (!identical(typedefElement, cycle)) {
- compiler.reportError(element,
+ compiler.reportErrorMessage(
+ element,
MessageKind.CYCLIC_TYPEDEF_ONE,
{'typedefName': element.name,
'otherTypedefName': cycle.name});
« no previous file with comments | « pkg/compiler/lib/src/resolution/type_resolver.dart ('k') | pkg/compiler/lib/src/resolution/variables.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698