pkg/compiler/lib/src/js_backend/namer.dart - Issue 1363993004: Report info messages together with their error, warning, or hint.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/namer.dart

Issue 1363993004: Report info messages together with their error, warning, or hint. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Updated cf. comment. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_backend/js_backend.dart ('k') | pkg/compiler/lib/src/js_backend/no_such_method_registry.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_backend/namer.dart

diff --git a/pkg/compiler/lib/src/js_backend/namer.dart b/pkg/compiler/lib/src/js_backend/namer.dart

index e60bc20065b11e7a2ea83311623a9a7e3222f3d1..14a399cd8aa583160559ad3e438647b9e1f8f7ee 100644

--- a/pkg/compiler/lib/src/js_backend/namer.dart

+++ b/pkg/compiler/lib/src/js_backend/namer.dart

@@ -513,8 +513,9 @@ class Namer {

case JsGetName.FUNCTION_CLASS_TYPE_NAME:

return runtimeTypeName(compiler.functionClass);

default:

- compiler.reportError(

- node, MessageKind.GENERIC,

+ compiler.reportErrorMessage(

+ node,

+ MessageKind.GENERIC,

{'text': 'Error: Namer has no name for "$name".'});

return asName('BROKEN');

}

« no previous file with comments | « pkg/compiler/lib/src/js_backend/js_backend.dart ('k') | pkg/compiler/lib/src/js_backend/no_such_method_registry.dart » ('j') | no next file with comments »