Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: pkg/compiler/lib/src/mirrors_used.dart

Issue 1363993004: Report info messages together with their error, warning, or hint. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated cf. comment. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/library_loader.dart ('k') | pkg/compiler/lib/src/native/behavior.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/mirrors_used.dart
diff --git a/pkg/compiler/lib/src/mirrors_used.dart b/pkg/compiler/lib/src/mirrors_used.dart
index 553f9ccae6bfb8c38c2beb3b56ebd0c1041621cd..2110d756722bf3881a8ca0861e0f32c80ec35ccc 100644
--- a/pkg/compiler/lib/src/mirrors_used.dart
+++ b/pkg/compiler/lib/src/mirrors_used.dart
@@ -409,9 +409,8 @@ class MirrorUsageBuilder {
MessageKind kind = onlyStrings
? MessageKind.MIRRORS_EXPECTED_STRING
: MessageKind.MIRRORS_EXPECTED_STRING_OR_TYPE;
- compiler.reportHint(
- node,
- kind, {'name': node, 'type': apiTypeOf(entry)});
+ compiler.reportHintMessage(
+ node, kind, {'name': node, 'type': apiTypeOf(entry)});
}
}
return result;
@@ -428,9 +427,8 @@ class MirrorUsageBuilder {
MessageKind kind = onlyStrings
? MessageKind.MIRRORS_EXPECTED_STRING_OR_LIST
: MessageKind.MIRRORS_EXPECTED_STRING_TYPE_OR_LIST;
- compiler.reportHint(
- node,
- kind, {'name': node, 'type': apiTypeOf(constant)});
+ compiler.reportHintMessage(
+ node, kind, {'name': node, 'type': apiTypeOf(constant)});
return null;
}
}
@@ -513,8 +511,9 @@ class MirrorUsageBuilder {
List<String> identifiers = expression.split('.');
Element element = enclosingLibrary.find(identifiers[0]);
if (element == null) {
- compiler.reportHint(
- spannable, MessageKind.MIRRORS_CANNOT_RESOLVE_IN_CURRENT_LIBRARY,
+ compiler.reportHintMessage(
+ spannable,
+ MessageKind.MIRRORS_CANNOT_RESOLVE_IN_CURRENT_LIBRARY,
{'name': expression});
return null;
} else {
@@ -531,12 +530,12 @@ class MirrorUsageBuilder {
if (e == null) {
if (current.isLibrary) {
LibraryElement library = current;
- compiler.reportHint(
+ compiler.reportHintMessage(
spannable, MessageKind.MIRRORS_CANNOT_RESOLVE_IN_LIBRARY,
{'name': identifiers[0],
'library': library.libraryOrScriptName});
} else {
- compiler.reportHint(
+ compiler.reportHintMessage(
spannable, MessageKind.MIRRORS_CANNOT_FIND_IN_ELEMENT,
{'name': identifier, 'element': current.name});
}
« no previous file with comments | « pkg/compiler/lib/src/library_loader.dart ('k') | pkg/compiler/lib/src/native/behavior.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698