Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: pkg/compiler/lib/src/deferred_load.dart

Issue 1363993004: Report info messages together with their error, warning, or hint. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated cf. comment. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/deferred_load.dart
diff --git a/pkg/compiler/lib/src/deferred_load.dart b/pkg/compiler/lib/src/deferred_load.dart
index bd9c01adea361a827c2323cf8602ad2f8e4189d7..9615406e633c66d28cff799fc436330663560960 100644
--- a/pkg/compiler/lib/src/deferred_load.dart
+++ b/pkg/compiler/lib/src/deferred_load.dart
@@ -729,7 +729,7 @@ class DeferredLoadTask extends CompilerTask {
compiler.constants.getConstantValue(metadata.constant);
Element element = value.getType(compiler.coreTypes).element;
if (element == deferredLibraryClass) {
- compiler.reportError(
+ compiler.reportErrorMessage(
import, MessageKind.DEFERRED_OLD_SYNTAX);
}
}
@@ -746,7 +746,8 @@ class DeferredLoadTask extends CompilerTask {
_allDeferredImports[key] = importedLibrary;
if (prefix == null) {
- compiler.reportError(import,
+ compiler.reportErrorMessage(
+ import,
MessageKind.DEFERRED_LIBRARY_WITHOUT_PREFIX);
} else {
prefixDeferredImport[prefix] = import;
@@ -762,7 +763,8 @@ class DeferredLoadTask extends CompilerTask {
ImportElement failingImport = (previousDeferredImport != null)
? previousDeferredImport
: import;
- compiler.reportError(failingImport.prefix,
+ compiler.reportErrorMessage(
+ failingImport.prefix,
MessageKind.DEFERRED_LIBRARY_DUPLICATE_PREFIX);
}
usedPrefixes.add(prefix);
« no previous file with comments | « pkg/compiler/lib/src/dart_backend/outputter.dart ('k') | pkg/compiler/lib/src/diagnostics/diagnostic_listener.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698