Issue 9340012: Move gpu client files to content_common, in content/common/gpu/client

Issue 9340012: Move gpu client files to content_common, in content/common/gpu/client (Closed)

Created:
8 years, 10 months ago by piman

Modified:
8 years, 10 months ago

Reviewers:
apatrick_chromium

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, jam, annacc+watch_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move gpu client files to content_common, in content/common/gpu/client BUG=99516 TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120729

Patch Set 1 : #

Total comments: 4

Patch Set 2 : remove unneeded enums #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+205 lines, -3933 lines)			Patch
A +	content/common/gpu/client/command_buffer_proxy.h	View		4 chunks	+5 lines, -5 lines	0 comments	Download
A +	content/common/gpu/client/command_buffer_proxy.cc	View		2 chunks	+2 lines, -3 lines	0 comments	Download
A +	content/common/gpu/client/content_gl_context.h	View	1	8 chunks	+36 lines, -38 lines	0 comments	Download
A +	content/common/gpu/client/content_gl_context.cc	View	1	18 chunks	+50 lines, -52 lines	0 comments	Download
A +	content/common/gpu/client/gpu_channel_host.h	View		5 chunks	+7 lines, -7 lines	0 comments	Download
A +	content/common/gpu/client/gpu_channel_host.cc	View		3 chunks	+5 lines, -5 lines	0 comments	Download
A +	content/common/gpu/client/gpu_video_decode_accelerator_host.h	View		3 chunks	+4 lines, -4 lines	0 comments	Download
A +	content/common/gpu/client/gpu_video_decode_accelerator_host.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A +	content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h	View		5 chunks	+7 lines, -7 lines	0 comments	Download
A +	content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc	View		9 chunks	+23 lines, -24 lines	0 comments	Download
M	content/content_common.gypi	View		2 chunks	+11 lines, -0 lines	0 comments	Download
M	content/content_renderer.gypi	View		2 chunks	+0 lines, -17 lines	0 comments	Download
D	content/renderer/gpu/command_buffer_proxy.h	View		1 chunk	+0 lines, -143 lines	0 comments	Download
D	content/renderer/gpu/command_buffer_proxy.cc	View		1 chunk	+0 lines, -413 lines	0 comments	Download
D	content/renderer/gpu/gpu_channel_host.h	View		1 chunk	+0 lines, -208 lines	0 comments	Download
D	content/renderer/gpu/gpu_channel_host.cc	View		1 chunk	+0 lines, -318 lines	0 comments	Download
D	content/renderer/gpu/gpu_video_decode_accelerator_host.h	View		1 chunk	+0 lines, -72 lines	0 comments	Download
D	content/renderer/gpu/gpu_video_decode_accelerator_host.cc	View		1 chunk	+0 lines, -171 lines	0 comments	Download
D	content/renderer/gpu/renderer_gl_context.h	View		1 chunk	+0 lines, -211 lines	0 comments	Download
D	content/renderer/gpu/renderer_gl_context.cc	View		1 chunk	+0 lines, -461 lines	0 comments	Download
D	content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.h	View		1 chunk	+0 lines, -533 lines	0 comments	Download
D	content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.cc	View		1 chunk	+0 lines, -1183 lines	0 comments	Download
M	content/renderer/media/pepper_platform_video_decoder_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/media/renderer_gpu_video_decoder_factories.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	content/renderer/media/renderer_gpu_video_decoder_factories.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	content/renderer/pepper_parent_context_provider.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/renderer/pepper_platform_context_3d_impl.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/renderer/pepper_platform_context_3d_impl.cc	View		4 chunks	+8 lines, -8 lines	0 comments	Download
M	content/renderer/pepper_plugin_delegate_impl.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/pepper_plugin_delegate_impl.cc	View		4 chunks	+4 lines, -6 lines	0 comments	Download
M	content/renderer/render_thread_impl.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/render_thread_impl.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	content/renderer/render_view_impl.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/render_view_impl.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	content/renderer/render_widget_fullscreen_pepper.h	View		4 chunks	+7 lines, -7 lines	0 comments	Download
M	content/renderer/render_widget_fullscreen_pepper.cc	View		7 chunks	+16 lines, -16 lines	0 comments	Download
M	content/renderer/renderer_webkitplatformsupport_impl.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	content/renderer/webplugin_delegate_proxy.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

piman

Note: this is written on top of https://chromiumcodereview.appspot.com/9270025/ which hasn't landed yet (but is about ...

8 years, 10 months ago (2012-02-06 22:49:10 UTC) #1

apatrick_chromium

LGTM with a couple of notes. https://chromiumcodereview.appspot.com/9340012/diff/2001/content/common/gpu/client/content_gl_context.cc File content/common/gpu/client/content_gl_context.cc (right): https://chromiumcodereview.appspot.com/9340012/diff/2001/content/common/gpu/client/content_gl_context.cc#newcode17 content/common/gpu/client/content_gl_context.cc:17: //#include "content/common/view_messages.h" This ...

8 years, 10 months ago (2012-02-06 23:05:55 UTC) #2

piman

https://chromiumcodereview.appspot.com/9340012/diff/2001/content/common/gpu/client/content_gl_context.cc File content/common/gpu/client/content_gl_context.cc (right): https://chromiumcodereview.appspot.com/9340012/diff/2001/content/common/gpu/client/content_gl_context.cc#newcode17 content/common/gpu/client/content_gl_context.cc:17: //#include "content/common/view_messages.h" On 2012/02/06 23:05:55, apatrick_chromium wrote: > This ...

8 years, 10 months ago (2012-02-06 23:25:32 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/9340012/2002

8 years, 10 months ago (2012-02-07 03:36:43 UTC) #5

Change committed as 120729

Expand Messages | Collapse Messages