Replace most of Browser::GetSelectedTabContents calls into Browser::GetSelectedWebContents. I've ...

Replace most of Browser::GetSelectedTabContents calls into Browser::GetSelectedWebContents. I've converted the easy ones, I'll do the ones with more dependencies in a separate change to keep things trivial to review.

I considered taking out GetSelectedTabContents altogether and having people just use GetSelectedTabContentsWrapper()->web_contents() per the existing comment in browser.h, but there are a lot of callers and it seemed too long to type.

BUG=98716
TBR=joi
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116122

[Jói, 2012-01-04 10:57:22]

LGTM

On Mon, Jan 2, 2012 at 10:30 PM, <jam@chromium.org> wrote:

> Reviewers: Jói,
>
> Description:
> Replace most of Browser::**GetSelectedTabContents calls into
> Browser::**GetSelectedWebContents. I've converted the easy ones, I'll do
> the ones
> with more dependencies in a separate change to keep things trivial to
> review.
>
> I considered taking out GetSelectedTabContents altogether and having
> people just
> use GetSelectedTabContentsWrapper(**)->web_contents() per the existing
> comment in
> browser.h, but there are a lot of callers and it seemed too long to type.
>
> BUG=98716
> TBR=joi
>
> Please review this at
http://codereview.chromium.**org/9015022/<http://codereview.chromium.org/9015...
>
> SVN Base: svn://chrome-svn/chrome/trunk/**src/
>
> Affected files:
>  M     chrome/browser/accessibility/**accessibility_win_browsertest.**cc
>  M     chrome/browser/accessibility/**dump_accessibility_tree_**
> browsertest.cc
>  M     chrome/browser/autofill/**autofill_browsertest.cc
>  M     chrome/browser/automation/**automation_provider.cc
>  M     chrome/browser/automation/**automation_provider_observers.**cc
>  M     chrome/browser/automation/**automation_tab_helper_**browsertest.cc
>  M     chrome/browser/automation/**testing_automation_provider.cc
>  M     chrome/browser/bookmarks/**bookmark_utils.h
>  M     chrome/browser/bookmarks/**bookmark_utils.cc
>  M     chrome/browser/browser_**commands_unittest.cc
>  M     chrome/browser/browser_focus_**uitest.cc
>  M     chrome/browser/chromeos/tab_**closeable_state_watcher_**
> browsertest.cc
>  M     chrome/browser/custom_**handlers/protocol_handler_**
> registry_browsertest.cc
>  M     chrome/browser/debugger/**devtools_window.h
>  M     chrome/browser/debugger/**devtools_window.cc
>  M     chrome/browser/download/**download_browsertest.cc
>  M     chrome/browser/extensions/app_**process_apitest.cc
>  M     chrome/browser/extensions/**browser_action_apitest.cc
>  M     chrome/browser/extensions/**chrome_app_api_browsertest.cc
>  M     chrome/browser/extensions/**content_script_apitest.cc
>  M     chrome/browser/extensions/**extension_browsertests_misc.cc
>  M     chrome/browser/extensions/**extension_context_menu_model.**cc
>  M     chrome/browser/extensions/**extension_crash_recovery_**
> browsertest.cc
>  M     chrome/browser/extensions/**extension_dom_clipboard_**apitest.cc
>  M     chrome/browser/extensions/**extension_file_browser_**private_api.cc
>  M     chrome/browser/extensions/**extension_icon_source_apitest.**cc
>  M     chrome/browser/extensions/**extension_incognito_apitest.cc
>  M     chrome/browser/extensions/**extension_install_ui_**browsertest.cc
>  M     chrome/browser/extensions/**extension_nacl_browsertest.cc
>  M     chrome/browser/extensions/**extension_override_apitest.cc
>  M     chrome/browser/extensions/**extension_process_manager.cc
>  M     chrome/browser/extensions/**extension_resource_request_**
> policy_apitest.cc
>  M     chrome/browser/extensions/**extension_startup_browsertest.**cc
>  M     chrome/browser/extensions/**extension_tabs_module.cc
>  M     chrome/browser/extensions/**extension_url_rewrite_**browsertest.cc
>  M     chrome/browser/extensions/**extension_webnavigation_**apitest.cc
>  M     chrome/browser/extensions/**extension_webrequest_apitest.**cc
>  M     chrome/browser/extensions/**lazy_background_page_apitest.**cc
>  M     chrome/browser/extensions/**page_action_apitest.cc
>  M     chrome/browser/extensions/**webstore_inline_install_**
> browsertest.cc
>  M     chrome/browser/external_tab_**container_win.cc
>  M     chrome/browser/geolocation/**geolocation_browsertest.cc
>  M     chrome/browser/gpu_pixel_**browsertest.cc
>  M     chrome/browser/instant/**instant_browsertest.cc
>  M     chrome/browser/magic_iframe_**browsertest.cc
>  M     chrome/browser/popup_blocker_**browsertest.cc
>  M     chrome/browser/prerender/**prerender_browsertest.cc
>  M     chrome/browser/printing/print_**dialog_cloud.cc
>  M     chrome/browser/printing/print_**dialog_cloud_uitest.cc
>  M     chrome/browser/safe_browsing/**safe_browsing_service_**
> browsertest.cc
>  M     chrome/browser/sessions/**session_restore.cc
>  M     chrome/browser/sessions/tab_**restore_service.cc
>  M     chrome/browser/sessions/tab_**restore_service_delegate.h
>  M     chrome/browser/speech/speech_**input_bubble_browsertest.cc
>  M     chrome/browser/ssl/ssl_**browser_tests.cc
>  M     chrome/browser/sync/test/**integration/sync_test.cc
>  M     chrome/browser/tab_contents/**render_view_context_menu_**
> browsertest.cc
>  M     chrome/browser/tab_contents/**web_drag_source_win.cc
>  M     chrome/browser/tabs/tab_**finder.h
>  M     chrome/browser/tabs/tab_**finder.cc
>  M     chrome/browser/task_manager/**task_manager_resource_**providers.cc
>  M     chrome/browser/ui/browser.h
>  M     chrome/browser/ui/browser.cc
>  M     chrome/browser/ui/browser_**browsertest.cc
>  M     chrome/browser/ui/browser_**close_browsertest.cc
>  M     chrome/browser/ui/browser_**init.cc
>  M     chrome/browser/ui/browser_**navigator_browsertest.cc
>  M     chrome/browser/ui/browser_**navigator_browsertest_**chromeos.cc
>  M     chrome/browser/ui/browser_tab_**restore_service_delegate.h
>  M     chrome/browser/ui/browser_tab_**restore_service_delegate.cc
>  M    
chrome/browser/ui/cocoa/**bookmarks/bookmark_bar_**controller.mm<http://bookmark_bar_controller.mm>
>  M    
chrome/browser/ui/cocoa/browse**r_window_cocoa.mm<http://browser_window_cocoa.mm>
>  M     chrome/browser/ui/cocoa/**browser_window_controller.h
>  M    
chrome/browser/ui/cocoa/browse**r_window_controller.mm<http://browser_window_controller.mm>
>  M    
chrome/browser/ui/cocoa/browse**r_window_controller_private.mm<http://browser_window_controller_private.mm>
>  M     chrome/browser/ui/cocoa/dev_**tools_controller.h
>  M    
chrome/browser/ui/cocoa/dev_**tools_controller.mm<http://dev_tools_controller.mm>
>  M     chrome/browser/ui/cocoa/**extensions/extension_action_**
> context_menu.mm <http://extension_action_context_menu.mm>
>  M     chrome/browser/ui/cocoa/fullsc**reen_exit_bubble_controller_**
> unittest.mm <http://fullscreen_exit_bubble_controller_unittest.mm>
>  M     chrome/browser/ui/cocoa/tab_**contents/tab_contents_**controller.h
>  M    
chrome/browser/ui/cocoa/tab_**contents/tab_contents_**controller.mm<http://tab_contents_controller.mm>
>  M     chrome/browser/ui/cocoa/tabpos**e_window.mm<http://tabpose_window.mm>
>  M     chrome/browser/ui/cocoa/**toolbar/toolbar_controller.mm
>  M     chrome/browser/ui/fullscreen_**controller.cc
>  M     chrome/browser/ui/gtk/**bookmarks/bookmark_bar_gtk.cc
>  M     chrome/browser/ui/gtk/browser_**titlebar.h
>  M     chrome/browser/ui/gtk/browser_**titlebar.cc
>  M     chrome/browser/ui/gtk/browser_**window_gtk.h
>  M     chrome/browser/ui/gtk/browser_**window_gtk.cc
>  M     chrome/browser/ui/gtk/gtk_**util.cc
>  M     chrome/browser/ui/gtk/omnibox/**omnibox_view_gtk.cc
>  M     chrome/browser/ui/intents/web_**intent_picker_controller_**
> browsertest.cc
>  M     chrome/browser/ui/omnibox/**omnibox_view_browsertest.cc
>  M     chrome/browser/ui/panels/**panel.h
>  M     chrome/browser/ui/panels/**panel.cc
>  M     chrome/browser/ui/panels/**panel_browser_frame_view.cc
>  M     chrome/browser/ui/panels/**panel_browsertest.cc
>  M     chrome/browser/ui/pdf/pdf_**browsertest.cc
>  M     chrome/browser/ui/toolbar/**toolbar_model.cc
>  M     chrome/browser/ui/toolbar/**wrench_menu_model.cc
>  M     chrome/browser/ui/toolbar/**wrench_menu_model_unittest.cc
>  M     chrome/browser/ui/views/**bookmarks/bookmark_bar_view.cc
>  M     chrome/browser/ui/views/**constrained_html_delegate_gtk.**cc
>  M     chrome/browser/ui/views/**constrained_html_delegate_**views.cc
>  M     chrome/browser/ui/views/find_**bar_host_interactive_uitest.cc
>  M     chrome/browser/ui/views/frame/**app_panel_browser_frame_view.**cc
>  M     chrome/browser/ui/views/frame/**browser_view.h
>  M     chrome/browser/ui/views/frame/**browser_view.cc
>  M     chrome/browser/ui/views/frame/**opaque_browser_frame_view.cc
>  M     chrome/browser/ui/views/html_**dialog_view_browsertest.cc
>  M     chrome/browser/ui/views/ssl_**client_certificate_selector_**
> browsertest.cc
>  M     chrome/browser/ui/views/tab_**contents/tab_contents_**container.h
>  M     chrome/browser/ui/views/tab_**contents/tab_contents_**container.cc
>  M     chrome/browser/ui/views/**wrench_menu.cc
>  M     chrome/browser/ui/webui/**active_downloads_ui.cc
>  M     chrome/browser/ui/webui/ntp/**app_launcher_handler.cc
>  M     chrome/browser/ui/webui/web_**ui_browsertest.cc
>  M     chrome/browser/ui/webui/**workers_ui_browsertest.cc
>  M     chrome/test/base/ui_test_**utils.h
>  M     chrome/test/base/ui_test_**utils.cc
>  M     chrome/test/data/webui/hung_**renderer_dialog_ui_test-inl.h
>  M     content/browser/accessibility/**renderer_accessibility_**
> browsertest.cc
>  M     content/browser/device_**orientation/device_**
> orientation_browsertest.cc
>  M     content/browser/download/**mhtml_generation_browsertest.**cc
>  M     content/browser/download/**mhtml_generation_manager.h
>  M     content/browser/download/**mhtml_generation_manager.cc
>  M     content/browser/file_system/**file_system_browsertest.cc
>  M     content/browser/in_process_**webkit/indexed_db_browsertest.**cc
>  M     content/browser/renderer_host/**render_process_host_**
> browsertest.cc
>  M     content/browser/renderer_host/**render_view_host_browsertest.**cc
>  M     content/browser/renderer_host/**render_view_host_manager_**
> browsertest.cc
>  M     content/browser/renderer_host/**resource_dispatcher_host_**
> browsertest.cc
>  M     content/browser/speech/speech_**input_browsertest.cc
>  M     content/browser/tab_contents/**tab_contents.cc
>  M     content/browser/webkit_**browsertest.cc
>  M     content/public/browser/**download_manager.h
>  M     content/public/browser/**notification_types.h
>
>
>