chrome/browser/extensions/extension_startup_browsertest.cc - Issue 9015022: Replace most of Browser::GetSelectedTabContents calls into Browser::GetSelectedWebContents. I've ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_startup_browsertest.cc

Issue 9015022: Replace most of Browser::GetSelectedTabContents calls into Browser::GetSelectedWebContents. I've ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 8 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_resource_request_policy_apitest.cc ('k') | chrome/browser/extensions/extension_tabs_module.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_startup_browsertest.cc

===================================================================

--- chrome/browser/extensions/extension_startup_browsertest.cc (revision 116109)

+++ chrome/browser/extensions/extension_startup_browsertest.cc (working copy)

@@ -18,9 +18,9 @@

#include "chrome/common/chrome_switches.h"

#include "chrome/test/base/in_process_browser_test.h"

#include "chrome/test/base/ui_test_utils.h"

-#include "content/browser/tab_contents/tab_contents.h"

#include "content/public/browser/notification_details.h"

#include "content/public/browser/notification_service.h"

+#include "content/public/browser/web_contents.h"

#include "net/base/net_util.h"

// This file contains high-level startup tests for the extensions system. We've

@@ -115,7 +115,7 @@

bool result = false;

ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractBool(

- browser()->GetSelectedTabContents()->GetRenderViewHost(), L"",

+ browser()->GetSelectedWebContents()->GetRenderViewHost(), L"",

L"window.domAutomationController.send("

L"document.defaultView.getComputedStyle(document.body, null)."

L"getPropertyValue('background-color') == 'rgb(245, 245, 220)')",

@@ -124,7 +124,7 @@

result = false;

ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractBool(

- browser()->GetSelectedTabContents()->GetRenderViewHost(), L"",

+ browser()->GetSelectedWebContents()->GetRenderViewHost(), L"",

L"window.domAutomationController.send(document.title == 'Modified')",

&result));

EXPECT_EQ(expect_script, result);