Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: chrome/browser/extensions/extension_icon_source_apitest.cc

Issue 9015022: Replace most of Browser::GetSelectedTabContents calls into Browser::GetSelectedWebContents. I've ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/logging.h" 5 #include "base/logging.h"
6 #include "chrome/browser/extensions/extension_apitest.h" 6 #include "chrome/browser/extensions/extension_apitest.h"
7 #include "chrome/browser/extensions/extension_service.h" 7 #include "chrome/browser/extensions/extension_service.h"
8 #include "chrome/browser/profiles/profile.h" 8 #include "chrome/browser/profiles/profile.h"
9 #include "chrome/browser/ui/browser.h" 9 #include "chrome/browser/ui/browser.h"
10 #include "chrome/browser/ui/browser_list.h" 10 #include "chrome/browser/ui/browser_list.h"
11 #include "chrome/common/chrome_switches.h" 11 #include "chrome/common/chrome_switches.h"
12 #include "chrome/test/base/ui_test_utils.h" 12 #include "chrome/test/base/ui_test_utils.h"
13 #include "content/browser/tab_contents/tab_contents.h" 13 #include "content/public/browser/web_contents.h"
14 #include "googleurl/src/gurl.h" 14 #include "googleurl/src/gurl.h"
15 #include "net/base/mock_host_resolver.h" 15 #include "net/base/mock_host_resolver.h"
16 16
17 class ExtensionIconSourceTest : public ExtensionApiTest { 17 class ExtensionIconSourceTest : public ExtensionApiTest {
18 protected: 18 protected:
19 virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { 19 virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
20 ExtensionApiTest::SetUpCommandLine(command_line); 20 ExtensionApiTest::SetUpCommandLine(command_line);
21 command_line->AppendSwitch(switches::kAllowLegacyExtensionManifests); 21 command_line->AppendSwitch(switches::kAllowLegacyExtensionManifests);
22 } 22 }
23 }; 23 };
24 24
25 IN_PROC_BROWSER_TEST_F(ExtensionIconSourceTest, IconsLoaded) { 25 IN_PROC_BROWSER_TEST_F(ExtensionIconSourceTest, IconsLoaded) {
26 FilePath basedir = test_data_dir_.AppendASCII("icons"); 26 FilePath basedir = test_data_dir_.AppendASCII("icons");
27 ASSERT_TRUE(LoadExtension(basedir.AppendASCII("extension_with_permission"))); 27 ASSERT_TRUE(LoadExtension(basedir.AppendASCII("extension_with_permission")));
28 ASSERT_TRUE(LoadExtension(basedir.AppendASCII("extension_no_permission"))); 28 ASSERT_TRUE(LoadExtension(basedir.AppendASCII("extension_no_permission")));
29 std::string result; 29 std::string result;
30 30
31 // Test that the icons are loaded and that the chrome://extension-icon 31 // Test that the icons are loaded and that the chrome://extension-icon
32 // parameters work correctly. 32 // parameters work correctly.
33 ui_test_utils::NavigateToURL( 33 ui_test_utils::NavigateToURL(
34 browser(), 34 browser(),
35 GURL("chrome-extension://gbmgkahjioeacddebbnengilkgbkhodg/index.html")); 35 GURL("chrome-extension://gbmgkahjioeacddebbnengilkgbkhodg/index.html"));
36 ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractString( 36 ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractString(
37 browser()->GetSelectedTabContents()->GetRenderViewHost(), L"", 37 browser()->GetSelectedWebContents()->GetRenderViewHost(), L"",
38 L"window.domAutomationController.send(document.title)", 38 L"window.domAutomationController.send(document.title)",
39 &result)); 39 &result));
40 EXPECT_EQ(result, "Loaded"); 40 EXPECT_EQ(result, "Loaded");
41 41
42 // Verify that the an extension can't load chrome://extension-icon icons 42 // Verify that the an extension can't load chrome://extension-icon icons
43 // without the management permission. 43 // without the management permission.
44 ui_test_utils::NavigateToURL( 44 ui_test_utils::NavigateToURL(
45 browser(), 45 browser(),
46 GURL("chrome-extension://apocjbpjpkghdepdngjlknfpmabcmlao/index.html")); 46 GURL("chrome-extension://apocjbpjpkghdepdngjlknfpmabcmlao/index.html"));
47 ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractString( 47 ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractString(
48 browser()->GetSelectedTabContents()->GetRenderViewHost(), L"", 48 browser()->GetSelectedWebContents()->GetRenderViewHost(), L"",
49 L"window.domAutomationController.send(document.title)", 49 L"window.domAutomationController.send(document.title)",
50 &result)); 50 &result));
51 EXPECT_EQ(result, "Not Loaded"); 51 EXPECT_EQ(result, "Not Loaded");
52 } 52 }
53 53
54 IN_PROC_BROWSER_TEST_F(ExtensionIconSourceTest, IconsLoadedIncognito) { 54 IN_PROC_BROWSER_TEST_F(ExtensionIconSourceTest, IconsLoadedIncognito) {
55 FilePath basedir = test_data_dir_.AppendASCII("icons"); 55 FilePath basedir = test_data_dir_.AppendASCII("icons");
56 ASSERT_TRUE(LoadExtensionIncognito( 56 ASSERT_TRUE(LoadExtensionIncognito(
57 basedir.AppendASCII("extension_with_permission"))); 57 basedir.AppendASCII("extension_with_permission")));
58 ASSERT_TRUE(LoadExtensionIncognito( 58 ASSERT_TRUE(LoadExtensionIncognito(
59 basedir.AppendASCII("extension_no_permission"))); 59 basedir.AppendASCII("extension_no_permission")));
60 std::string result; 60 std::string result;
61 61
62 // Test that the icons are loaded and that the chrome://extension-icon 62 // Test that the icons are loaded and that the chrome://extension-icon
63 // parameters work correctly. 63 // parameters work correctly.
64 ui_test_utils::OpenURLOffTheRecord( 64 ui_test_utils::OpenURLOffTheRecord(
65 browser()->profile(), 65 browser()->profile(),
66 GURL("chrome-extension://gbmgkahjioeacddebbnengilkgbkhodg/index.html")); 66 GURL("chrome-extension://gbmgkahjioeacddebbnengilkgbkhodg/index.html"));
67 Browser* otr_browser = BrowserList::FindTabbedBrowser( 67 Browser* otr_browser = BrowserList::FindTabbedBrowser(
68 browser()->profile()->GetOffTheRecordProfile(), false); 68 browser()->profile()->GetOffTheRecordProfile(), false);
69 ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractString( 69 ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractString(
70 otr_browser->GetSelectedTabContents()->GetRenderViewHost(), L"", 70 otr_browser->GetSelectedWebContents()->GetRenderViewHost(), L"",
71 L"window.domAutomationController.send(document.title)", 71 L"window.domAutomationController.send(document.title)",
72 &result)); 72 &result));
73 EXPECT_EQ(result, "Loaded"); 73 EXPECT_EQ(result, "Loaded");
74 74
75 // Verify that the an extension can't load chrome://extension-icon icons 75 // Verify that the an extension can't load chrome://extension-icon icons
76 // without the management permission. 76 // without the management permission.
77 ui_test_utils::OpenURLOffTheRecord( 77 ui_test_utils::OpenURLOffTheRecord(
78 browser()->profile(), 78 browser()->profile(),
79 GURL("chrome-extension://apocjbpjpkghdepdngjlknfpmabcmlao/index.html")); 79 GURL("chrome-extension://apocjbpjpkghdepdngjlknfpmabcmlao/index.html"));
80 ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractString( 80 ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractString(
81 otr_browser->GetSelectedTabContents()->GetRenderViewHost(), L"", 81 otr_browser->GetSelectedWebContents()->GetRenderViewHost(), L"",
82 L"window.domAutomationController.send(document.title)", 82 L"window.domAutomationController.send(document.title)",
83 &result)); 83 &result));
84 EXPECT_EQ(result, "Not Loaded"); 84 EXPECT_EQ(result, "Not Loaded");
85 } 85 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698