Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: chrome/browser/extensions/extension_crash_recovery_browsertest.cc

Issue 9015022: Replace most of Browser::GetSelectedTabContents calls into Browser::GetSelectedWebContents. I've ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 8 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_crash_recovery_browsertest.cc
===================================================================
--- chrome/browser/extensions/extension_crash_recovery_browsertest.cc (revision 116109)
+++ chrome/browser/extensions/extension_crash_recovery_browsertest.cc (working copy)
@@ -18,10 +18,12 @@
#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
#include "chrome/test/base/ui_test_utils.h"
#include "content/browser/renderer_host/render_view_host.h"
-#include "content/browser/tab_contents/tab_contents.h"
#include "content/public/browser/render_process_host.h"
+#include "content/public/browser/web_contents.h"
#include "content/public/common/result_codes.h"
+using content::WebContents;
+
class ExtensionCrashRecoveryTest : public ExtensionBrowserTest {
protected:
ExtensionService* GetExtensionService() {
@@ -163,7 +165,7 @@
SCOPED_TRACE("after reloading");
CheckExtensionConsistency(first_extension_id_);
- TabContents* current_tab = browser()->GetSelectedTabContents();
+ WebContents* current_tab = browser()->GetSelectedWebContents();
ASSERT_TRUE(current_tab);
// The balloon should automatically hide after the extension is successfully
@@ -178,13 +180,13 @@
CrashExtension(first_extension_id_);
ASSERT_EQ(size_before, GetExtensionService()->extensions()->size());
- TabContents* original_tab = browser()->GetSelectedTabContents();
+ WebContents* original_tab = browser()->GetSelectedWebContents();
ASSERT_TRUE(original_tab);
ASSERT_EQ(1U, CountBalloons());
// Open a new tab, but the balloon will still be there.
browser()->NewTab();
- TabContents* new_current_tab = browser()->GetSelectedTabContents();
+ WebContents* new_current_tab = browser()->GetSelectedWebContents();
ASSERT_TRUE(new_current_tab);
ASSERT_NE(new_current_tab, original_tab);
ASSERT_EQ(1U, CountBalloons());
@@ -206,7 +208,7 @@
CrashExtension(first_extension_id_);
ASSERT_EQ(size_before, GetExtensionService()->extensions()->size());
- TabContents* current_tab = browser()->GetSelectedTabContents();
+ WebContents* current_tab = browser()->GetSelectedWebContents();
ASSERT_TRUE(current_tab);
ASSERT_EQ(1U, CountBalloons());
@@ -379,7 +381,7 @@
{
SCOPED_TRACE("first: reload");
- TabContents* current_tab = browser()->GetSelectedTabContents();
+ WebContents* current_tab = browser()->GetSelectedWebContents();
ASSERT_TRUE(current_tab);
// At the beginning we should have one balloon displayed for each extension.
ASSERT_EQ(2U, CountBalloons());
@@ -472,7 +474,7 @@
ui_test_utils::WindowedNotificationObserver observer(
content::NOTIFICATION_LOAD_STOP,
content::Source<NavigationController>(
- &browser()->GetSelectedTabContentsWrapper()->tab_contents()->
+ &browser()->GetSelectedTabContentsWrapper()->web_contents()->
GetController()));
browser()->Reload(CURRENT_TAB);
observer.Wait();

Powered by Google App Engine
This is Rietveld 408576698