Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(984)

Unified Diff: chrome/browser/extensions/extension_override_apitest.cc

Issue 9015022: Replace most of Browser::GetSelectedTabContents calls into Browser::GetSelectedWebContents. I've ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 8 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_override_apitest.cc
===================================================================
--- chrome/browser/extensions/extension_override_apitest.cc (revision 116109)
+++ chrome/browser/extensions/extension_override_apitest.cc (working copy)
@@ -14,7 +14,10 @@
#include "chrome/test/base/ui_test_utils.h"
#include "content/browser/tab_contents/tab_contents.h"
#include "content/public/browser/navigation_entry.h"
+#include "content/public/browser/web_contents.h"
+using content::WebContents;
+
class ExtensionOverrideTest : public ExtensionApiTest {
protected:
bool CheckHistoryOverridesContainsNoDupes() {
@@ -47,7 +50,7 @@
// extension URL.
void NavigateToKeyboard() {
ui_test_utils::NavigateToURL(browser(), GURL("chrome://keyboard/"));
- TabContents* tab = browser()->GetSelectedTabContents();
+ WebContents* tab = browser()->GetSelectedWebContents();
ASSERT_TRUE(tab->GetController().GetActiveEntry());
EXPECT_TRUE(tab->GetController().GetActiveEntry()->url().
SchemeIs(chrome::kExtensionScheme));
@@ -62,7 +65,7 @@
// Navigate to the new tab page. The overridden new tab page
// will call chrome.test.notifyPass() .
ui_test_utils::NavigateToURL(browser(), GURL("chrome://newtab/"));
- TabContents* tab = browser()->GetSelectedTabContents();
+ WebContents* tab = browser()->GetSelectedWebContents();
ASSERT_TRUE(tab->GetController().GetActiveEntry());
EXPECT_TRUE(tab->GetController().GetActiveEntry()->GetURL().
SchemeIs(chrome::kExtensionScheme));
@@ -89,7 +92,7 @@
GURL("chrome://newtab/"));
Browser* otr_browser = BrowserList::FindTabbedBrowser(
browser()->profile()->GetOffTheRecordProfile(), false);
- TabContents* tab = otr_browser->GetSelectedTabContents();
+ WebContents* tab = otr_browser->GetSelectedWebContents();
ASSERT_TRUE(tab->GetController().GetActiveEntry());
EXPECT_FALSE(tab->GetController().GetActiveEntry()->GetURL().
SchemeIs(chrome::kExtensionScheme));
« no previous file with comments | « chrome/browser/extensions/extension_nacl_browsertest.cc ('k') | chrome/browser/extensions/extension_process_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698