Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: chrome/browser/browser_commands_unittest.cc

Issue 9015022: Replace most of Browser::GetSelectedTabContents calls into Browser::GetSelectedWebContents. I've ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 8 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/bookmarks/bookmark_utils.cc ('k') | chrome/browser/browser_focus_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_commands_unittest.cc
===================================================================
--- chrome/browser/browser_commands_unittest.cc (revision 116109)
+++ chrome/browser/browser_commands_unittest.cc (working copy)
@@ -161,14 +161,14 @@
CommitPendingLoad(&second->GetController());
browser()->GoBack(NEW_FOREGROUND_TAB);
ASSERT_EQ(3, browser()->active_index());
- ASSERT_EQ(url1, browser()->GetSelectedTabContents()->GetURL());
+ ASSERT_EQ(url1, browser()->GetSelectedWebContents()->GetURL());
// Same thing again for forward.
// TODO(brettw) bug 11055: see the comment above about why we need this.
- CommitPendingLoad(&browser()->GetSelectedTabContents()->GetController());
+ CommitPendingLoad(&browser()->GetSelectedWebContents()->GetController());
browser()->GoForward(NEW_FOREGROUND_TAB);
ASSERT_EQ(4, browser()->active_index());
- ASSERT_EQ(url2, browser()->GetSelectedTabContents()->GetURL());
+ ASSERT_EQ(url2, browser()->GetSelectedWebContents()->GetURL());
}
// Tests IDC_SEARCH (the Search key on Chrome OS devices).
@@ -178,13 +178,13 @@
GURL non_ntp_url("http://foo/");
AddTab(browser(), non_ntp_url);
ASSERT_EQ(1, browser()->tab_count());
- EXPECT_EQ(non_ntp_url, browser()->GetSelectedTabContents()->GetURL());
+ EXPECT_EQ(non_ntp_url, browser()->GetSelectedWebContents()->GetURL());
// Pressing the Search key should open a new tab containing the NTP.
browser()->Search();
ASSERT_EQ(2, browser()->tab_count());
ASSERT_EQ(1, browser()->active_index());
- GURL current_url = browser()->GetSelectedTabContents()->GetURL();
+ GURL current_url = browser()->GetSelectedWebContents()->GetURL();
EXPECT_TRUE(current_url.SchemeIs(chrome::kChromeUIScheme));
EXPECT_EQ(chrome::kChromeUINewTabHost, current_url.host());
@@ -192,7 +192,7 @@
browser()->Search();
ASSERT_EQ(2, browser()->tab_count());
ASSERT_EQ(1, browser()->active_index());
- current_url = browser()->GetSelectedTabContents()->GetURL();
+ current_url = browser()->GetSelectedWebContents()->GetURL();
EXPECT_TRUE(current_url.SchemeIs(chrome::kChromeUIScheme));
EXPECT_EQ(chrome::kChromeUINewTabHost, current_url.host());
}
« no previous file with comments | « chrome/browser/bookmarks/bookmark_utils.cc ('k') | chrome/browser/browser_focus_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698