chrome/browser/extensions/extension_install_ui_browsertest.cc - Issue 9015022: Replace most of Browser::GetSelectedTabContents calls into Browser::GetSelectedWebContents. I've ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_install_ui_browsertest.cc

Issue 9015022: Replace most of Browser::GetSelectedTabContents calls into Browser::GetSelectedWebContents. I've ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 8 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_incognito_apitest.cc ('k') | chrome/browser/extensions/extension_nacl_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_install_ui_browsertest.cc

===================================================================

--- chrome/browser/extensions/extension_install_ui_browsertest.cc (revision 116109)

+++ chrome/browser/extensions/extension_install_ui_browsertest.cc (working copy)

@@ -12,8 +12,10 @@

#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"

#include "chrome/browser/themes/theme_service_factory.h"

#include "chrome/test/base/ui_test_utils.h"

-#include "content/browser/tab_contents/tab_contents.h"

+#include "content/public/browser/web_contents.h"

+using content::WebContents;

class ExtensionInstallUIBrowserTest : public ExtensionBrowserTest {

public:

// Checks that a theme info bar is currently visible and issues an undo to

@@ -108,9 +110,9 @@

browser()->profile()));

EXPECT_EQ(num_tabs + 1, browser()->tab_count());

- TabContents* tab_contents = browser()->GetSelectedTabContents();

- ASSERT_TRUE(tab_contents);

- EXPECT_TRUE(StartsWithASCII(tab_contents->GetURL().spec(),

+ WebContents* web_contents = browser()->GetSelectedWebContents();

+ ASSERT_TRUE(web_contents);

+ EXPECT_TRUE(StartsWithASCII(web_contents->GetURL().spec(),

"chrome://newtab/", false));

}

@@ -129,8 +131,8 @@

EXPECT_EQ(num_incognito_tabs, incognito_browser->tab_count());

EXPECT_EQ(num_normal_tabs + 1, browser()->tab_count());