Report errors and warnings for hiding elements, issue 572.

Report errors and warnings for hiding elements, issue 572.
http://code.google.com/p/dart/issues/detail?id=572

R=zundel@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=2636

[zundel, 2011-12-19 16:29:13]

http://codereview.chromium.org/8966029/diff/1/client/samples/total/src/Functi...
File client/samples/total/src/Functions.dart (right):

http://codereview.chromium.org/8966029/diff/1/client/samples/total/src/Functi...
client/samples/total/src/Functions.dart:598: _newFunc("COUNT", -1, (CellLocation
location, List<Value> stack, int top, int nargs) {
I would leave these statments unchanged.  They aren't masking anything, and the
type annotations could perform a function (double checking the return value is
correctly typed)

http://codereview.chromium.org/8966029/diff/1/client/tests/client/samples/tot...
File client/tests/client/samples/total/total_tests.dart (right):

http://codereview.chromium.org/8966029/diff/1/client/tests/client/samples/tot...
client/tests/client/samples/total/total_tests.dart:156: {
Can you re-indent the body of this new block?

http://codereview.chromium.org/8966029/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/resolver/ClassScope.java (right):

http://codereview.chromium.org/8966029/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/resolver/ClassScope.java:37: if (element
instanceof TypeVariableElement) {
just a thought: you could merge these two if blocks together into a single
switch.  I only prefer it in case the logic needs to be updated, its sometimes
easier to figure out the switch statement that lots of ifs.

switch (ElementKind.of(element)){
  case TYPE_VARIABLE:
    return null;
  case NONE: 
    break;
  default:
    return element;
}

http://codereview.chromium.org/8966029/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java
(right):

http://codereview.chromium.org/8966029/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java:52:
DUPLICATE_FUNCTION_EXPRESSION_WARNING(ErrorSeverity.WARNING, "Function
expression '%s' is hiding '%s' at %s"),
line > 100chars

http://codereview.chromium.org/8966029/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java:54:
DUPLICATE_LOCAL_VARIABLE_WARNING(ErrorSeverity.WARNING, "Local variable '%s' is
hiding '%s' at %s"),
line > 100 chars

[scheglov, 2011-12-19 19:10:38]

http://codereview.chromium.org/8966029/diff/1/client/samples/total/src/Functi...
File client/samples/total/src/Functions.dart (right):

http://codereview.chromium.org/8966029/diff/1/client/samples/total/src/Functi...
client/samples/total/src/Functions.dart:598: _newFunc("COUNT", -1, (CellLocation
location, List<Value> stack, int top, int nargs) {
On 2011/12/19 16:29:14, zundel wrote:
> I would leave these statments unchanged.  They aren't masking anything, and
the
> type annotations could perform a function (double checking the return value is
> correctly typed)

  I've restored types, but I have to tweak function names.
  Total is compiled with warnings as errors, so I have to fix them somehow.

http://codereview.chromium.org/8966029/diff/1/client/tests/client/samples/tot...
File client/tests/client/samples/total/total_tests.dart (right):

http://codereview.chromium.org/8966029/diff/1/client/tests/client/samples/tot...
client/tests/client/samples/total/total_tests.dart:156: {
On 2011/12/19 16:29:14, zundel wrote:
> Can you re-indent the body of this new block?

Done.

http://codereview.chromium.org/8966029/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/resolver/ClassScope.java (right):

http://codereview.chromium.org/8966029/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/resolver/ClassScope.java:37: if (element
instanceof TypeVariableElement) {
On 2011/12/19 16:29:14, zundel wrote:
> just a thought: you could merge these two if blocks together into a single
> switch.  I only prefer it in case the logic needs to be updated, its sometimes
> easier to figure out the switch statement that lots of ifs.
> 
> switch (ElementKind.of(element)){
>   case TYPE_VARIABLE:
>     return null;
>   case NONE: 
>     break;
>   default:
>     return element;
> }
>   

Done.

http://codereview.chromium.org/8966029/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java
(right):

http://codereview.chromium.org/8966029/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java:52:
DUPLICATE_FUNCTION_EXPRESSION_WARNING(ErrorSeverity.WARNING, "Function
expression '%s' is hiding '%s' at %s"),
On 2011/12/19 16:29:14, zundel wrote:
> line > 100chars

Done.

http://codereview.chromium.org/8966029/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java:54:
DUPLICATE_LOCAL_VARIABLE_WARNING(ErrorSeverity.WARNING, "Local variable '%s' is
hiding '%s' at %s"),
On 2011/12/19 16:29:14, zundel wrote:
> line > 100 chars

Done.

[zundel, 2011-12-19 19:56:20]

lgtm