Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: client/samples/isolate/IsolateSample.dart

Issue 8966029: Report errors and warnings for hiding elements, issue 572. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fixes for comments Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/samples/dartcombat/state.dart ('k') | client/samples/spirodraw/Spirodraw.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/samples/isolate/IsolateSample.dart
diff --git a/client/samples/isolate/IsolateSample.dart b/client/samples/isolate/IsolateSample.dart
index 215d2d738668f0df7f7dfd12b9a86b81f9e79dc2..c5b708ef02438ba7fa266ce97dd5fbecbe1c35e2 100644
--- a/client/samples/isolate/IsolateSample.dart
+++ b/client/samples/isolate/IsolateSample.dart
@@ -72,8 +72,8 @@ class IsolateSample {
String greeting = document.query("#greetingText").dynamic.value;
var message = { "id": MessageId.GREETING, "args" : [ greeting ] };
ports[isolateName].call(message).receive(
- (var message, SendPort replyTo) {
- replyElement.text = message;
+ (var msg, SendPort replyTo) {
+ replyElement.text = msg;
});
});
}
@@ -121,9 +121,9 @@ class DemoIsolate extends Isolate {
});
}
- void init(String isolateName, SendPort chirpPort) {
- this.isolateName = isolateName;
- this.chirpPort = chirpPort;
+ void init(String isolateName_, SendPort chirpPort_) {
+ this.isolateName = isolateName_;
+ this.chirpPort = chirpPort_;
div = new Element.tag("div");
div.classes = ["isolate", "isolate${isolateName}"];
div.innerHTML = document.query("#isolateTemplate").
@@ -131,7 +131,7 @@ class DemoIsolate extends Isolate {
div.query(".isolateName").text = isolateName;
document.query("#isolateParent").nodes.add(div);
div.query(".chirpButton").on.click.add(
- void _(Event) { chirpPort.call(
+ void _(event) { chirpPort.call(
"this is a chirp message from isolate " + isolateName);
}, false);
}
« no previous file with comments | « client/samples/dartcombat/state.dart ('k') | client/samples/spirodraw/Spirodraw.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698