Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: client/samples/dartcombat/state.dart

Issue 8966029: Report errors and warnings for hiding elements, issue 572. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fixes for comments Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/layout/GridLayout.dart ('k') | client/samples/isolate/IsolateSample.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/samples/dartcombat/state.dart
diff --git a/client/samples/dartcombat/state.dart b/client/samples/dartcombat/state.dart
index f2772d8fda336c1db16ffc3e9dd4f9028e2dea30..c215cc0117fbbf2550c7d47ef1e2155bc20fab2d 100644
--- a/client/samples/dartcombat/state.dart
+++ b/client/samples/dartcombat/state.dart
@@ -183,7 +183,7 @@ class PlayerState extends Isolate {
static final DOWN_DIR = const [0, 1];
Future<bool> _exploreAllDirections(int x, int y, bool parallel) {
- Completer<bool> superShot = new Completer<bool>();
+ Completer<bool> superShot_ = new Completer<bool>();
if (parallel) {
final arr = new List<Future<bool>>();
arr.add(_exploreDirectionHelper(LEFT_DIR, x, y));
@@ -191,15 +191,15 @@ class PlayerState extends Isolate {
arr.add(_exploreDirectionHelper(UP_DIR, x, y));
arr.add(_exploreDirectionHelper(DOWN_DIR, x, y));
Futures.wait(arr).then((arrValues) {
- superShot.complete(true);
+ superShot_.complete(true);
});
} else {
- _seqExploreDirectionHelper(LEFT_DIR, x, y, superShot,
- _seqExploreDirectionHelper(RIGHT_DIR, x, y, superShot,
- _seqExploreDirectionHelper(UP_DIR, x, y, superShot,
- _seqExploreDirectionHelper(DOWN_DIR, x, y, superShot, null))))(false);
+ _seqExploreDirectionHelper(LEFT_DIR, x, y, superShot_,
+ _seqExploreDirectionHelper(RIGHT_DIR, x, y, superShot_,
+ _seqExploreDirectionHelper(UP_DIR, x, y, superShot_,
+ _seqExploreDirectionHelper(DOWN_DIR, x, y, superShot_, null))))(false);
}
- return superShot.future;
+ return superShot_.future;
}
Function _seqExploreDirectionHelper(List<int> dir, int x, int y,
Completer<bool> seq, void _next(bool res)) {
« no previous file with comments | « client/layout/GridLayout.dart ('k') | client/samples/isolate/IsolateSample.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698