Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: client/testing/unittest/unittest.dart

Issue 8966029: Report errors and warnings for hiding elements, issue 572. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fixes for comments Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/testing/unittest/shared.dart ('k') | client/testing/unittest/unittest_dartest.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/testing/unittest/unittest.dart
diff --git a/client/testing/unittest/unittest.dart b/client/testing/unittest/unittest.dart
index 4c6a9d52b37aff0309c3e9602b3c7cb02e1c1bc0..064577140fdbfe4ac71c53b2def6c853508ccfdb 100644
--- a/client/testing/unittest/unittest.dart
+++ b/client/testing/unittest/unittest.dart
@@ -56,8 +56,8 @@ _platformCompleteTests(int testsPassed, int testsFailed, int testsErrors) {
? "<tr><td colspan='3' class='unittest-pass'>PASS</td></tr>"
: "<tr><td colspan='3' class='unittest-fail'>FAIL</td></tr>");
- for (final test in _tests) {
- newBody.add(_toHtml(test));
+ for (final test_ in _tests) {
+ newBody.add(_toHtml(test_));
}
if (testsPassed == _tests.length) {
@@ -78,11 +78,11 @@ _platformCompleteTests(int testsPassed, int testsFailed, int testsErrors) {
window.postMessage('unittest-suite-done', '*');
}
-String _toHtml(TestCase test) {
- if (!test.isComplete) {
+String _toHtml(TestCase test_) {
+ if (!test_.isComplete) {
return '''
<tr>
- <td>${test.id}</td>
+ <td>${test_.id}</td>
<td class="unittest-error">NO STATUS</td>
<td>Test did not complete</td>
</tr>''';
@@ -90,14 +90,14 @@ String _toHtml(TestCase test) {
var html = '''
<tr>
- <td>${test.id}</td>
- <td class="unittest-${test.result}">${test.result.toUpperCase()}</td>
- <td>Expectation: ${test.description}. ${test.message}</td>
+ <td>${test_.id}</td>
+ <td class="unittest-${test_.result}">${test_.result.toUpperCase()}</td>
+ <td>Expectation: ${test_.description}. ${test_.message}</td>
</tr>''';
- if (test.stackTrace != null) {
+ if (test_.stackTrace != null) {
html +=
- '<tr><td></td><td colspan="2"><pre>${test.stackTrace}</pre></td></tr>';
+ '<tr><td></td><td colspan="2"><pre>${test_.stackTrace}</pre></td></tr>';
}
return html;
« no previous file with comments | « client/testing/unittest/shared.dart ('k') | client/testing/unittest/unittest_dartest.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698