Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: client/testing/dartest/dartest.dart

Issue 8966029: Report errors and warnings for hiding elements, issue 572. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fixes for comments Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/samples/total/src/SpreadsheetPresenter.dart ('k') | client/testing/unittest/shared.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/testing/dartest/dartest.dart
diff --git a/client/testing/dartest/dartest.dart b/client/testing/dartest/dartest.dart
index 6501fd0ee4bba24c85c42a76b4e467df20647827..786871f3933c36b3cab7d95485db1f646d9660d7 100644
--- a/client/testing/dartest/dartest.dart
+++ b/client/testing/dartest/dartest.dart
@@ -166,17 +166,17 @@ class DARTest{
}
/** Update the UI after running test. */
- void _updateDARTestUI(TestCase test) {
- _updateResultsTable(test, window);
+ void _updateDARTestUI(TestCase test_) {
+ _updateResultsTable(test_, window);
if(_runnerWindow != window) {
- _updateResultsTable(test, _runnerWindow);
+ _updateResultsTable(test_, _runnerWindow);
}
- if(test.result != null) {
- _log(' Result: ${test.result.toUpperCase()} ${test.message}');
+ if(test_.result != null) {
+ _log(' Result: ${test_.result.toUpperCase()} ${test_.message}');
}
- if(test.runningTime != null) {
- _log(' took ${_printDuration(test.runningTime)}');
+ if(test_.runningTime != null) {
+ _log(' took ${_printDuration(test_.runningTime)}');
}
_updateStatusProgress(_appElements);
if(_runnerWindow != window) {
@@ -240,15 +240,15 @@ class DARTest{
headDiv.innerHTML = 'DARTest: In-App View';
HTMLImageElement close = _runnerWindow.document.createElement('img');
close.className = 'dt-header-close';
- close.addEventListener('click', (Event) {
+ close.addEventListener('click', (event) {
containerDiv.className = 'dt-hide';
}, true);
HTMLImageElement pop = _runnerWindow.document.createElement('img');
pop.className = 'dt-header-pop';
- pop.addEventListener('click', (Event) => _dartestMaximize(), true);
+ pop.addEventListener('click', (event) => _dartestMaximize(), true);
HTMLImageElement minMax = _runnerWindow.document.createElement('img');
minMax.className = 'dt-header-min';
- minMax.addEventListener('click', (Event) {
+ minMax.addEventListener('click', (event) {
if (mainElem.classList.contains('dt-hide')) {
mainElem.classList.remove('dt-hide');
mainElem.classList.add('dt-show');
@@ -275,13 +275,13 @@ class DARTest{
HTMLLIElement coverageTab = _runnerWindow.document.createElement('li');
testingTab.className = 'dt-tab-selected';
testingTab.textContent = 'Testing';
- testingTab.addEventListener('click', (Event) {
+ testingTab.addEventListener('click', (event) {
_showTestControls();
_changeTabs(testingTab, coverageTab);
}, true);
tabList.appendChild(testingTab);
coverageTab.textContent = 'Coverage';
- coverageTab.addEventListener('click', (Event) {
+ coverageTab.addEventListener('click', (event) {
_showCoverageControls();
_changeTabs(coverageTab, testingTab);
}, true);
@@ -293,7 +293,7 @@ class DARTest{
HTMLDivElement popIn = _runnerWindow.document.createElement('div');
popIn.className = 'dt-minimize';
popIn.innerHTML = 'Pop In ⇲';
- popIn.addEventListener('click', (Event) => _dartestMinimize(), true);
+ popIn.addEventListener('click', (event) => _dartestMinimize(), true);
containerDiv.appendChild(popIn);
}
@@ -319,7 +319,7 @@ class DARTest{
runBtn.innerHTML = '►';
runBtn.title = 'Run Tests';
runBtn.className = 'dt-button dt-run';
- runBtn.addEventListener('click', (Event) {
+ runBtn.addEventListener('click', (event) {
_log('Running tests');
updateUI = _updateDARTestUI;
runDartests();
« no previous file with comments | « client/samples/total/src/SpreadsheetPresenter.dart ('k') | client/testing/unittest/shared.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698