compiler/javatests/com/google/dart/compiler/backend/js/testClosureOpt.dart - Issue 8966029: Report errors and warnings for hiding elements, issue 572.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/javatests/com/google/dart/compiler/backend/js/testClosureOpt.dart

Issue 8966029: Report errors and warnings for hiding elements, issue 572. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fixes for comments Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/util/Paths.java ('k') | compiler/javatests/com/google/dart/compiler/backend/js/testListSubTypeExprOpt.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/javatests/com/google/dart/compiler/backend/js/testClosureOpt.dart

diff --git a/compiler/javatests/com/google/dart/compiler/backend/js/testClosureOpt.dart b/compiler/javatests/com/google/dart/compiler/backend/js/testClosureOpt.dart

index 16f62a6d43b9dce2771c3fc6bdb8b115d568bf2c..c94653582fc56b02745b136e69b28c5b50bcc08a 100644

--- a/compiler/javatests/com/google/dart/compiler/backend/js/testClosureOpt.dart

+++ b/compiler/javatests/com/google/dart/compiler/backend/js/testClosureOpt.dart

@@ -16,42 +16,42 @@ class A {

{

int s4 = 4;

- var _fn_0 = int () => 0; // hoisted

+ var _fn_0 = int _() => 0; // hoisted

- var _fn_1 = int (p1) => p1; // hoisted

+ var _fn_1 = int _(p1) => p1; // hoisted

- var _fn_2 = int (p1, p2) => p1 + p2; // hoisted

+ var _fn_2 = int _(p1, p2) => p1 + p2; // hoisted

- var _fn_3 = int (p1, p2, p3) => p1 + p2 + p3; // hoisted

+ var _fn_3 = int _(p1, p2, p3) => p1 + p2 + p3; // hoisted

- var _fn_4 = int (p1, p2, p3, p4) => p1 + p2 + p3 + p4; // hoisted

+ var _fn_4 = int _(p1, p2, p3, p4) => p1 + p2 + p3 + p4; // hoisted

- var _fn_5 = int () => s1; // bind 1-0

+ var _fn_5 = int _() => s1; // bind 1-0

- var _fn_6 = int () => s1 + s2; // bind 2-0

+ var _fn_6 = int _() => s1 + s2; // bind 2-0

- var _fn_7 = int () => s1 + s2 + s3; // bind 3-0

+ var _fn_7 = int _() => s1 + s2 + s3; // bind 3-0

- var _fn_8 = int () => s1 + s2 + s3 + s4; // bind

+ var _fn_8 = int _() => s1 + s2 + s3 + s4; // bind

- var _fn_9 = int (p1) => p1 + s1; // bind 1-1

+ var _fn_9 = int _(p1) => p1 + s1; // bind 1-1

- var _fn_A = int (p1, p2) => p1 + p2 + s1 + s2; // bind 2-2

+ var _fn_A = int _(p1, p2) => p1 + p2 + s1 + s2; // bind 2-2

- var _fn_B = int (p1, p2, p3) => p1 + p2 + p3 + s1 + s2 + s3; // bind 3-3

+ var _fn_B = int _(p1, p2, p3) => p1 + p2 + p3 + s1 + s2 + s3; // bind 3-3

// bind

- var _fn_C = int (p1, p2, p3, p4) => p1 + p2 + p3 + p4 + s1 + s2 + s3 + s4;

+ var _fn_C = int _(p1, p2, p3, p4) => p1 + p2 + p3 + p4 + s1 + s2 + s3 + s4;

// cannot inline - named args

- var _fn_D = int (p1, [n1 = 20]) => p1 + s1 + n1;

+ var _fn_D = int _(p1, [n1 = 20]) => p1 + s1 + n1;

- var _fn_E = int (p1) => p1 + s1 + this.x;

+ var _fn_E = int _(p1) => p1 + s1 + this.x;

- var _fn_F = int (p1) => p1 + s1 + arg1;

+ var _fn_F = int _(p1) => p1 + s1 + arg1;

}