Report errors and warnings for hiding elements, issue 572.

client/samples/total/src/Functions.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // Functions implemented:
 //
 // ABS ACOS ACOSH AND ASIN ASINH ATAN ATAN2 ATANH COLUMNS COMBIN CONCATENATE COS COSH COUNTA DATE
 // DAY DEGREES EVEN EXP FACT FACTDOUBLE FALSE GCD HLOOKUP HOUR IF INT LARGE LCM LEN LN LOG
 // LOG10 MATCH MAX MID MIN MINUTE MOD MONTH MULTINOMIAL NOT NOW ODD OFFSET OR PI POWER
 // PRODUCT QUOTIENT RADIANS RAND RANDBETWEEN RIGHT ROUND SECOND SERIESSUM SIGN
@@ skipping 577 matching lines @@
         stack[top] = new BooleanValue(true);
       });
     _newFunc("CONCATENATE", -2,
       void _(CellLocation location, List<Value> stack, int top, int nargs) {
         StringBuffer sb = new StringBuffer();
         for (int i = 0; i < nargs; i++) {
           sb.add(stack[top + i].asString(location));
         }
         stack[top] = new StringValue(sb.toString());
       });
-    _newFunc("COUNT", -1, void _(CellLocation location, List<Value> stack, int top, int nargs) {
+    _newFunc("COUNT", -1, (CellLocation location, List<Value> stack, int top, int nargs) {

[zundel, 2011/12/19 16:29:14]

I would leave these statments unchanged.  They aren't masking anything, and the
type annotations could perform a function (double checking the return value is
correctly typed)

[scheglov, 2011/12/19 19:10:38]

  I've restored types, but I have to tweak function names.
  Total is compiled with warnings as errors, so I have to fix them somehow.

         int count = 0;
         for (int i = 0; i < nargs; i++) {
           Value value = stack[top + i];
           if (value.datatype == Value.TYPE_CELLREF || value.datatype == Value.TYPE_RANGE) {
             count += _countCellsInRange(value.asRangeToken().getCellRange(location),
-              int _(Cell cell) { return cell.isNumeric() ? 1 : 0; });
+              (Cell cell) { return cell.isNumeric() ? 1 : 0; });
           } else if (value.datatype == Value.TYPE_DOUBLE) {
             count++;
           }
         }
         stack[top] = new DoubleValue(count.toDouble());
       });
-    _newFunc("COUNTA", -1, void _(CellLocation location, List<Value> stack, int top, int nargs) {
+    _newFunc("COUNTA", -1, (CellLocation location, List<Value> stack, int top, int nargs) {
         int count = 0;
         for (int i = 0; i < nargs; i++) {
           Value value = stack[top + i];
           if (value.datatype == Value.TYPE_CELLREF || value.datatype == Value.TYPE_RANGE) {
             count += _countCellsInRange(value.asRangeToken().getCellRange(location),
-              int _(Cell cell) { return cell.isEmpty() ? 0 : 1; });
+              (Cell cell) { return cell.isEmpty() ? 0 : 1; });
           } else {
             count++;
           }
         }
         stack[top] = new DoubleValue(count.toDouble());
       });
     _newFunc("GCD", -2, void _(CellLocation location, List<Value> stack, int top, int nargs) {
         for (int i = 0; i < nargs; i++) {
           if (stack[top + i].asDouble(location) < 0.0) {
             throw new NumberException();
@@ skipping 79 matching lines @@
         double xpow = Math.pow(x, n);
         double xstep = Math.pow(x, m);
         double sum = 0.0;
         for (int i = 3; i < nargs; i++) {
           sum += xpow * stack[top + i].asDouble(location);
           xpow *= xstep;
         }
         stack[top] = new DoubleValue(sum);
       });
 
-    _newFunc("MATCH", -2, void _(CellLocation location, List<Value> stack, int top, int nargs) {
+    _newFunc("MATCH", -2, (CellLocation location, List<Value> stack, int top, int nargs) {
         double value = stack[top].asDouble(location);
         RangeToken rt = stack[top + 1].asRangeToken();
         CellRange range = rt.getCellRange(location);
 
         int matchType = 1;
         if (nargs > 2) {
           matchType = stack[top + 2].asDouble(location).floor().toInt();
         }
 
         // The range must be 1xN or Nx1
         if (range.rows > 1 && range.columns > 1) {
           throw new NumberException();
         }
 
         int index = 1;
         double bestValue = matchType == 1 ? -1.0e100 : 1.0e100;
         int bestIndex = -1;
-        range.forEach(_(CellLocation loc) {
+        range.forEach((CellLocation loc) {
           Cell cell = loc.getCell();
           if (cell != null) {
             double d = cell.getDoubleValue();
             if (d == value) {
               bestIndex = index;
               return;
             } else if (matchType == 1 && d < value && d > bestValue) {
               bestValue = d;
               bestIndex = index;
             } else if (matchType == -1 && d > value && d < bestValue) {
@@ skipping 228 matching lines @@
       Cell resultCell = range.spreadsheet.getCell(horizontal ?
           new RowCol(outRowCol, bestIndex) : new RowCol(bestIndex, outRowCol));
       stack[top] = new DoubleValue(resultCell == null ? 0.0 : resultCell.getDoubleValue());
     }
   }
 
   void _newFunc(String name, int nargs, NumericFunction f) {
     _functions[name] = new SpreadsheetFunction(name, nargs, f);
   }
 }