Issue 8965046: Coverity: Fixing pass by value bugs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8965046: Coverity: Fixing pass by value bugs (Closed)

Created:
9 years ago by dpapad

Modified:
9 years ago

Reviewers:
James Hawkins

CC:
chromium-reviews, jstritar+watch_chromium.org, Aaron Boodman, mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Coverity: Fixing pass by value bugs CID= 101435, 101591, 101592, 101512, 100534 BUG=NONE TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115215

Patch Set 1 #

Patch Set 2 : Fixing more bugs. #

Patch Set 3 : 101512 #

Patch Set 4 : Fixing 100534 #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
M	chrome/browser/extensions/apps_promo.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/apps_promo.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/base/cookie_monster.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ppapi/cpp/dev/video_decoder_dev.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/cpp/dev/video_decoder_dev.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/gfx/render_text.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpapad@chromium.org/8965046/7001

9 years ago (2011-12-20 23:08:43 UTC) #3

commit-bot: I haz the power

9 years ago (2011-12-20 23:08:47 UTC) #4

Presubmit check for 8965046-7001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
ppapi/cpp/dev/video_decoder_dev.h,net/base/cookie_monster.cc,ppapi/cpp/dev/video_decoder_dev.cc,ui/gfx/render_text.h

Presubmit checks took 1.4s to calculate.

Expand Messages | Collapse Messages