ppapi/cpp/dev/video_decoder_dev.cc - Issue 8965046: Coverity: Fixing pass by value bugs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/cpp/dev/video_decoder_dev.cc

Issue 8965046: Coverity: Fixing pass by value bugs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing 100534 Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/cpp/dev/video_decoder_dev.cc

diff --git a/ppapi/cpp/dev/video_decoder_dev.cc b/ppapi/cpp/dev/video_decoder_dev.cc

index 7110695ac5ec0c2f4df4941ed7e01179ba4a80a8..dcc731229074f9fa5c1b1dcf10e36f390a7596bc 100644

--- a/ppapi/cpp/dev/video_decoder_dev.cc

+++ b/ppapi/cpp/dev/video_decoder_dev.cc

@@ -69,7 +69,7 @@ int32_t VideoDecoder_Dev::Flush(CompletionCallback callback) {

pp_resource(), callback.pp_completion_callback());

}

-int32_t VideoDecoder_Dev::Reset(CompletionCallback callback) {

+int32_t VideoDecoder_Dev::Reset(const CompletionCallback& callback) {

if (!has_interface<PPB_VideoDecoder_Dev>())

return callback.MayForce(PP_ERROR_NOINTERFACE);

return get_interface<PPB_VideoDecoder_Dev>()->Reset(

« no previous file with comments | « ppapi/cpp/dev/video_decoder_dev.h ('k') | ui/gfx/render_text.h » ('j') | no next file with comments »