ppapi/cpp/dev/video_decoder_dev.h - Issue 8965046: Coverity: Fixing pass by value bugs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ppapi/cpp/dev/video_decoder_dev.h

Issue 8965046: Coverity: Fixing pass by value bugs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing 100534 Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « net/base/cookie_monster.cc ('k') | ppapi/cpp/dev/video_decoder_dev.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef PPAPI_CPP_DEV_VIDEO_DECODER_DEV_H_	5 #ifndef PPAPI_CPP_DEV_VIDEO_DECODER_DEV_H_

6 #define PPAPI_CPP_DEV_VIDEO_DECODER_DEV_H_	6 #define PPAPI_CPP_DEV_VIDEO_DECODER_DEV_H_

7	7

8 #include <vector>	8 #include <vector>

9	9

10 #include "ppapi/c/dev/pp_video_dev.h"	10 #include "ppapi/c/dev/pp_video_dev.h"

(...skipping 19 matching lines...) Expand all Loading...
30	30

31 explicit VideoDecoder_Dev(PP_Resource resource);	31 explicit VideoDecoder_Dev(PP_Resource resource);

32 virtual ~VideoDecoder_Dev();	32 virtual ~VideoDecoder_Dev();

33	33

34 // PPB_VideoDecoder_Dev implementation.	34 // PPB_VideoDecoder_Dev implementation.

35 void AssignPictureBuffers(const std::vector<PP_PictureBuffer_Dev>& buffers);	35 void AssignPictureBuffers(const std::vector<PP_PictureBuffer_Dev>& buffers);

36 int32_t Decode(const PP_VideoBitstreamBuffer_Dev& bitstream_buffer,	36 int32_t Decode(const PP_VideoBitstreamBuffer_Dev& bitstream_buffer,

37 CompletionCallback callback);	37 CompletionCallback callback);

38 void ReusePictureBuffer(int32_t picture_buffer_id);	38 void ReusePictureBuffer(int32_t picture_buffer_id);

39 int32_t Flush(CompletionCallback callback);	39 int32_t Flush(CompletionCallback callback);

40 int32_t Reset(CompletionCallback callback);	40 int32_t Reset(const CompletionCallback& callback);

41	41

42 private:	42 private:

43 // Disallow copy-construction to ensure Destroy() is called exactly once.	43 // Disallow copy-construction to ensure Destroy() is called exactly once.

44 VideoDecoder_Dev(const VideoDecoder_Dev&);	44 VideoDecoder_Dev(const VideoDecoder_Dev&);

45 };	45 };

46	46

47 } // namespace pp	47 } // namespace pp

48	48

49 #endif // PPAPI_CPP_DEV_VIDEO_DECODER_DEV_H_	49 #endif // PPAPI_CPP_DEV_VIDEO_DECODER_DEV_H_

OLD	NEW