chrome/browser/extensions/apps_promo.cc - Issue 8965046: Coverity: Fixing pass by value bugs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/apps_promo.cc

Issue 8965046: Coverity: Fixing pass by value bugs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing 100534 Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/apps_promo.cc

diff --git a/chrome/browser/extensions/apps_promo.cc b/chrome/browser/extensions/apps_promo.cc

index 38483a33162ba4019a14563d1707d10703b87bc6..e5c9681dea322de90e947109f55cdf6c98f793c0 100644

--- a/chrome/browser/extensions/apps_promo.cc

+++ b/chrome/browser/extensions/apps_promo.cc

@@ -312,7 +312,7 @@ AppsPromo::UserGroup AppsPromo::GetCurrentUserGroup() const {

AppsPromoLogoFetcher::AppsPromoLogoFetcher(

Profile* profile,

- AppsPromo::PromoData promo_data)

+ const AppsPromo::PromoData& promo_data)

: profile_(profile),

promo_data_(promo_data) {

if (SupportsLogoURL()) {

« no previous file with comments | « chrome/browser/extensions/apps_promo.h ('k') | net/base/cookie_monster.cc » ('j') | no next file with comments »