net/base/cookie_monster.cc - Issue 8965046: Coverity: Fixing pass by value bugs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/cookie_monster.cc

Issue 8965046: Coverity: Fixing pass by value bugs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing 100534 Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/cookie_monster.cc

diff --git a/net/base/cookie_monster.cc b/net/base/cookie_monster.cc

index 44b110e55e537d76dde000f4fbc1bec90d6b2d99..f0bddf62f19cbdc32633d0a78fa3beaa1f7278b9 100644

--- a/net/base/cookie_monster.cc

+++ b/net/base/cookie_monster.cc

@@ -828,7 +828,7 @@ class CookieMonster::GetCookiesWithOptionsTask

: public CookieMonster::CookieMonsterTask {

public:

GetCookiesWithOptionsTask(CookieMonster* cookie_monster,

- GURL url,

+ const GURL& url,

const CookieOptions& options,

const CookieMonster::GetCookiesCallback& callback)

: CookieMonsterTask(cookie_monster),

@@ -895,7 +895,7 @@ class CookieMonster::DeleteCookieTask

: public CookieMonster::CookieMonsterTask {

public:

DeleteCookieTask(CookieMonster* cookie_monster,

- GURL url,

+ const GURL& url,

const std::string& cookie_name,

const base::Closure& callback)

: CookieMonsterTask(cookie_monster),

« no previous file with comments | « chrome/browser/extensions/apps_promo.cc ('k') | ppapi/cpp/dev/video_decoder_dev.h » ('j') | no next file with comments »