Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Side by Side Diff: ppapi/cpp/dev/video_decoder_dev.cc

Issue 8965046: Coverity: Fixing pass by value bugs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing 100534 Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ppapi/cpp/dev/video_decoder_dev.h ('k') | ui/gfx/render_text.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ppapi/cpp/dev/video_decoder_dev.h" 5 #include "ppapi/cpp/dev/video_decoder_dev.h"
6 6
7 #include "ppapi/c/dev/ppb_video_decoder_dev.h" 7 #include "ppapi/c/dev/ppb_video_decoder_dev.h"
8 #include "ppapi/c/dev/ppp_video_decoder_dev.h" 8 #include "ppapi/c/dev/ppp_video_decoder_dev.h"
9 #include "ppapi/c/pp_errors.h" 9 #include "ppapi/c/pp_errors.h"
10 #include "ppapi/cpp/graphics_3d.h" 10 #include "ppapi/cpp/graphics_3d.h"
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 pp_resource(), picture_buffer_id); 62 pp_resource(), picture_buffer_id);
63 } 63 }
64 64
65 int32_t VideoDecoder_Dev::Flush(CompletionCallback callback) { 65 int32_t VideoDecoder_Dev::Flush(CompletionCallback callback) {
66 if (!has_interface<PPB_VideoDecoder_Dev>()) 66 if (!has_interface<PPB_VideoDecoder_Dev>())
67 return callback.MayForce(PP_ERROR_NOINTERFACE); 67 return callback.MayForce(PP_ERROR_NOINTERFACE);
68 return get_interface<PPB_VideoDecoder_Dev>()->Flush( 68 return get_interface<PPB_VideoDecoder_Dev>()->Flush(
69 pp_resource(), callback.pp_completion_callback()); 69 pp_resource(), callback.pp_completion_callback());
70 } 70 }
71 71
72 int32_t VideoDecoder_Dev::Reset(CompletionCallback callback) { 72 int32_t VideoDecoder_Dev::Reset(const CompletionCallback& callback) {
73 if (!has_interface<PPB_VideoDecoder_Dev>()) 73 if (!has_interface<PPB_VideoDecoder_Dev>())
74 return callback.MayForce(PP_ERROR_NOINTERFACE); 74 return callback.MayForce(PP_ERROR_NOINTERFACE);
75 return get_interface<PPB_VideoDecoder_Dev>()->Reset( 75 return get_interface<PPB_VideoDecoder_Dev>()->Reset(
76 pp_resource(), callback.pp_completion_callback()); 76 pp_resource(), callback.pp_completion_callback());
77 } 77 }
78 78
79 } // namespace pp 79 } // namespace pp
OLDNEW
« no previous file with comments | « ppapi/cpp/dev/video_decoder_dev.h ('k') | ui/gfx/render_text.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698