Coverity: Fixing pass by value bugs

chrome/browser/extensions/apps_promo.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_APPS_PROMO_H_
 #define CHROME_BROWSER_EXTENSIONS_APPS_PROMO_H_
 #pragma once
 
 #include <set>
 #include <string>
@@ skipping 128 matching lines @@
   ExtensionIdSet old_default_app_ids_;
 
   DISALLOW_COPY_AND_ASSIGN(AppsPromo);
 };
 
 // Fetches logos over HTTPS, making sure we don't send cookies and that we
 // cache the image until its source URL changes.
 class AppsPromoLogoFetcher : public content::URLFetcherDelegate {
  public:
   AppsPromoLogoFetcher(Profile* profile,
-                       AppsPromo::PromoData promo_data);
+                       const AppsPromo::PromoData& promo_data);
   virtual ~AppsPromoLogoFetcher();
 
   virtual void OnURLFetchComplete(const content::URLFetcher* source) OVERRIDE;
 
  private:
   // Fetches the logo and stores the result as a data URL.
   void FetchLogo();
 
   // Checks if the logo was downloaded previously.
   bool HaveCachedLogo();
 
   // Sets the apps promo based on the current data and then issues the
   // WEB_STORE_PROMO_LOADED notification so open NTPs can inject the promo.
   void SavePromo();
 
   // Checks if the promo logo matches https://*.google.com/*.png.
   bool SupportsLogoURL();
 
   Profile* profile_;
   AppsPromo::PromoData promo_data_;
   scoped_ptr<content::URLFetcher> url_fetcher_;
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_APPS_PROMO_H_