Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8956050: Rename TabContents::controller() to GetController and put it into the WebContents interface. (Closed)

Created:
9 years ago by jam
Modified:
9 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, asanka, nkostylev+watch_chromium.org, tburkard+watch_chromium.org, dhollowa+watch_chromium.org, mihaip+watch_chromium.org, dcheng, ajwong+watch_chromium.org, stevenjb+watch_chromium.org, yusukes+watch_chromium.org, GeorgeY, cbentzel+watch_chromium.org, Ilya Sherman, kkania, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, jstritar+watch_chromium.org, Avi (use Gerrit), creis+watch_chromium.org, rdsmith+dwatch_chromium.org, Randy Smith (Not in Mondays), dpranke-watch+content_chromium.org, achuith+watch_chromium.org, tfarina, Aaron Boodman, dominich+watch_chromium.org, robertshield, mmenke, dyu1, Paweł Hajdan Jr., estade+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Rename TabContents::controller() to GetController and put it into the WebContents interface. BUG=98716 TBR=dpranke Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115276

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : sync #

Patch Set 4 : sync #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+569 lines, -541 lines) Patch
M chrome/browser/alternate_nav_url_fetcher.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_feedback_infobar_delegate.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/automation/automation_provider_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 2 12 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/background/background_contents_service.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_commands_unittest.cc View 1 2 3 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/browser_focus_uitest.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/browser_keyevents_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bug_report_util.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/boot_times_loader.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/notifications/balloon_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/tab_specific_content_settings.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/crash_recovery_browsertest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/debugger/devtools_sanity_unittest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/debugger/devtools_window.cc View 1 2 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/download/download_request_limiter.cc View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/errorpage_browsertest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/app_process_apitest.cc View 1 2 3 4 9 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/extensions/extension_browser_event_router.cc View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_browsertests_misc.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_crash_recovery_browsertest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_host.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_message_service.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_override_apitest.cc View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_page_actions_module.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_tab_util.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_tabs_module.cc View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_url_rewrite_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_web_ui.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_webstore_private_api.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/isolated_app_browsertest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/webstore_inline_installer.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/external_tab_container_win.cc View 1 2 3 4 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/favicon/favicon_tab_helper.cc View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/geolocation/chrome_geolocation_permission_context.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/geolocation/geolocation_browsertest.cc View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/infobars/infobar_delegate.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/infobars/infobar_tab_helper.cc View 1 2 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/instant/instant_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/instant/instant_controller.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/instant/instant_loader.cc View 1 2 14 chunks +19 lines, -18 lines 0 comments Download
M chrome/browser/memory_details.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/notifications/balloon_host.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/omnibox_search_hint.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/password_manager_delegate_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_preview_tab_controller.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/repost_form_warning_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/browser_feature_extractor.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/malware_details.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 1 2 3 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc View 1 2 3 4 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_restore.cc View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sessions/session_service.cc View 1 2 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/sessions/tab_restore_service.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sidebar/sidebar_browsertest.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sidebar/sidebar_container.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 1 2 18 chunks +28 lines, -28 lines 0 comments Download
M chrome/browser/tab_contents/background_contents.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 2 6 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/web_drag_bookmark_handler_gtk.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/web_drag_bookmark_handler_mac.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/web_drop_target_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tabs/pinned_tab_codec.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/tabs/tab_finder.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/tabs/tab_strip_model.cc View 1 2 9 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model_order_controller.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model_unittest.cc View 1 2 4 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/translate/options_menu_model.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_infobar_delegate.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_manager.cc View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/translate/translate_manager_browsertest.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/translate/translate_tab_helper.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/auto_login_prompter.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/blocked_content/blocked_content_tab_helper.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_tab_helper.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 28 chunks +35 lines, -34 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 2 3 4 8 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/tab_applescript.mm View 1 2 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_html_delegate_mac.mm View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/html_dialog_window_controller.mm View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/notifications/balloon_controller.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/collected_cookies_infobar_delegate.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/find_bar/find_bar_controller.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/constrained_html_delegate_gtk.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/html_dialog_gtk.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/web_intent_picker_gtk.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/login/login_prompt.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/login/login_prompt_browsertest.cc View 1 2 13 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/ui/pdf/pdf_browsertest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/search_engines/search_engine_tab_helper.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/sync/tab_contents_wrapper_synced_tab_delegate.cc View 1 2 1 chunk +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/tab_modal_confirm_dialog_delegate.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/back_forward_menu_model.cc View 1 2 6 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_model.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/toolbar_model_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/constrained_html_delegate_gtk.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/constrained_html_delegate_views.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/dom_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/click_handler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/notifications/balloon_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/sad_tab_view.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/tab_contents_container.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/web_applications/web_app_ui.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/active_downloads_ui.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/bug_report_ui.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/cloud_print_signin_dialog.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/recently_closed_tabs_handler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/cros_language_options_handler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview_handler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/web_ui_browsertest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/web_ui_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/browser_with_test_window_test.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/base/test_html_dialog_observer.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/base/test_tab_strip_model_observer.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/ui_test_utils.cc View 1 2 7 chunks +7 lines, -7 lines 0 comments Download
M content/browser/child_process_security_policy_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/debugger/devtools_http_handler_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/save_package.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/test_render_view_host.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/speech/speech_input_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/ssl/ssl_error_handler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/interstitial_page.cc View 1 2 6 chunks +8 lines, -8 lines 0 comments Download
M content/browser/tab_contents/navigation_controller_unittest.cc View 1 2 7 chunks +10 lines, -10 lines 0 comments Download
M content/browser/tab_contents/render_view_host_manager_unittest.cc View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M content/browser/tab_contents/tab_contents.h View 1 2 2 chunks +5 lines, -18 lines 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 1 2 7 chunks +18 lines, -6 lines 0 comments Download
M content/browser/tab_contents/tab_contents_unittest.cc View 1 2 9 chunks +15 lines, -15 lines 0 comments Download
M content/browser/tab_contents/test_tab_contents.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/browser/web_contents.h View 1 2 3 chunks +13 lines, -0 lines 0 comments Download
M content/shell/shell.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
yet another one :)
9 years ago (2011-12-20 23:55:49 UTC) #1
tfarina
http://codereview.chromium.org/8956050/diff/1159/content/public/browser/web_contents.h File content/public/browser/web_contents.h (right): http://codereview.chromium.org/8956050/diff/1159/content/public/browser/web_contents.h#newcode16 content/public/browser/web_contents.h:16: class TabContentsDelegate; This should be WebContentsDelegate now, unless my ...
9 years ago (2011-12-20 23:58:40 UTC) #2
jam
http://codereview.chromium.org/8956050/diff/1159/content/public/browser/web_contents.h File content/public/browser/web_contents.h (right): http://codereview.chromium.org/8956050/diff/1159/content/public/browser/web_contents.h#newcode16 content/public/browser/web_contents.h:16: class TabContentsDelegate; On 2011/12/20 23:58:41, tfarina wrote: > This ...
9 years ago (2011-12-21 00:01:38 UTC) #3
Dirk Pranke
9 years ago (2011-12-21 21:49:32 UTC) #4 
lgtm. Minor nit in that you renamed set_view_type() to SetViewType() also, so
your description was wrong :).

Powered by Google App Engine
This is Rietveld 408576698