chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc - Issue 8956050: Rename TabContents::controller() to GetController and put it into the WebContents interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

Issue 8956050: Rename TabContents::controller() to GetController and put it into the WebContents interface. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_blocking_page.cc ('k') | chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

===================================================================

--- chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc (revision 115228)

+++ chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc (working copy)

@@ -423,7 +423,7 @@

content::NOTIFICATION_LOAD_STOP,

content::Source<NavigationController>(

&browser()->GetSelectedTabContentsWrapper()->tab_contents()->

- controller()));

+ GetController()));

SendCommand("\"proceed\""); // Simulate the user clicking "proceed"

observer.Wait();

AssertNoInterstitial(true); // Assert the interstitial is gone.

@@ -452,7 +452,7 @@

content::NOTIFICATION_LOAD_STOP,

content::Source<NavigationController>(

&browser()->GetSelectedTabContentsWrapper()->tab_contents()->

- controller()));

+ GetController()));

SendCommand("\"proceed\""); // Simulate the user clicking "proceed".

observer.Wait();

AssertNoInterstitial(true); // Assert the interstitial is gone

@@ -469,7 +469,7 @@

content::NOTIFICATION_LOAD_STOP,

content::Source<NavigationController>(

&browser()->GetSelectedTabContentsWrapper()->tab_contents()->

- controller()));

+ GetController()));

SendCommand("\"reportError\""); // Simulate the user clicking "report error"

observer.Wait();

AssertNoInterstitial(false); // Assert the interstitial is gone

@@ -490,7 +490,7 @@

content::NOTIFICATION_LOAD_STOP,

content::Source<NavigationController>(

&browser()->GetSelectedTabContentsWrapper()->tab_contents()->

- controller()));

+ GetController()));

SendCommand("\"learnMore\""); // Simulate the user clicking "learn more"

observer.Wait();

AssertNoInterstitial(false); // Assert the interstitial is gone

@@ -511,7 +511,7 @@

content::NOTIFICATION_NAV_ENTRY_COMMITTED,

content::Source<NavigationController>(

&browser()->GetSelectedTabContentsWrapper()->tab_contents()->

- controller()));

+ GetController()));

SendCommand("\"takeMeBack\""); // Simulate the user clicking "back"

observer.Wait();

AssertNoInterstitial(false); // Assert the interstitial is gone