chrome/test/base/test_html_dialog_observer.cc - Issue 8956050: Rename TabContents::controller() to GetController and put it into the WebContents interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/base/test_html_dialog_observer.cc

Issue 8956050: Rename TabContents::controller() to GetController and put it into the WebContents interface. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/base/test_html_dialog_observer.cc

===================================================================

--- chrome/test/base/test_html_dialog_observer.cc (revision 115228)

+++ chrome/test/base/test_html_dialog_observer.cc (working copy)

@@ -48,13 +48,13 @@

// navigate in this method, ensuring that this is not a race condition.

registrar_.Add(this, content::NOTIFICATION_LOAD_STOP,

content::Source<NavigationController>(

- &web_ui_->tab_contents()->controller()));

+ &web_ui_->tab_contents()->GetController()));

break;

case content::NOTIFICATION_LOAD_STOP:

DCHECK(web_ui_);

registrar_.Remove(this, content::NOTIFICATION_LOAD_STOP,

content::Source<NavigationController>(

- &web_ui_->tab_contents()->controller()));

+ &web_ui_->tab_contents()->GetController()));

done_ = true;

// If the message loop is running stop it.

if (running_) {

« no previous file with comments | « chrome/test/base/browser_with_test_window_test.cc ('k') | chrome/test/base/test_tab_strip_model_observer.cc » ('j') | no next file with comments »