Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Unified Diff: chrome/browser/favicon/favicon_tab_helper.cc

Issue 8956050: Rename TabContents::controller() to GetController and put it into the WebContents interface. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/favicon/favicon_tab_helper.cc
===================================================================
--- chrome/browser/favicon/favicon_tab_helper.cc (revision 115228)
+++ chrome/browser/favicon/favicon_tab_helper.cc (working copy)
@@ -42,7 +42,7 @@
SkBitmap FaviconTabHelper::GetFavicon() const {
// Like GetTitle(), we also want to use the favicon for the last committed
// entry rather than a pending navigation entry.
- const NavigationController& controller = tab_contents()->controller();
+ const NavigationController& controller = tab_contents()->GetController();
NavigationEntry* entry = controller.GetTransientEntry();
if (entry)
return entry->favicon().bitmap();
@@ -54,7 +54,7 @@
}
bool FaviconTabHelper::FaviconIsValid() const {
- const NavigationController& controller = tab_contents()->controller();
+ const NavigationController& controller = tab_contents()->GetController();
NavigationEntry* entry = controller.GetTransientEntry();
if (entry)
return entry->favicon().is_valid();
@@ -68,7 +68,7 @@
bool FaviconTabHelper::ShouldDisplayFavicon() {
// Always display a throbber during pending loads.
- const NavigationController& controller = tab_contents()->controller();
+ const NavigationController& controller = tab_contents()->GetController();
if (controller.GetLastCommittedEntry() && controller.pending_entry())
return true;
@@ -79,7 +79,7 @@
}
void FaviconTabHelper::SaveFavicon() {
- NavigationEntry* entry = tab_contents()->controller().GetActiveEntry();
+ NavigationEntry* entry = tab_contents()->GetController().GetActiveEntry();
if (!entry || entry->url().is_empty())
return;
@@ -128,7 +128,7 @@
}
NavigationEntry* FaviconTabHelper::GetActiveEntry() {
- return tab_contents()->controller().GetActiveEntry();
+ return tab_contents()->GetController().GetActiveEntry();
}
void FaviconTabHelper::StartDownload(int id, const GURL& url, int image_size) {
« no previous file with comments | « chrome/browser/external_tab_container_win.cc ('k') | chrome/browser/geolocation/chrome_geolocation_permission_context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698