Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: content/browser/tab_contents/render_view_host_manager_unittest.cc

Issue 8956050: Rename TabContents::controller() to GetController and put it into the WebContents interface. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/tab_contents/render_view_host_manager_unittest.cc
===================================================================
--- content/browser/tab_contents/render_view_host_manager_unittest.cc (revision 115228)
+++ content/browser/tab_contents/render_view_host_manager_unittest.cc (working copy)
@@ -168,7 +168,7 @@
// Load the two URLs in the second tab. Note that the first navigation creates
// a RVH that's not pending (since there is no cross-site transition), so
// we use the committed one.
- contents2.controller().LoadURL(
+ contents2.GetController().LoadURL(
kNtpUrl, content::Referrer(), content::PAGE_TRANSITION_LINK,
std::string());
TestRenderViewHost* ntp_rvh2 = static_cast<TestRenderViewHost*>(
@@ -178,7 +178,7 @@
// The second one is the opposite, creating a cross-site transition and
// requiring a beforeunload ack.
- contents2.controller().LoadURL(
+ contents2.GetController().LoadURL(
kDestUrl, content::Referrer(), content::PAGE_TRANSITION_LINK,
std::string());
EXPECT_TRUE(contents2.cross_navigation_pending());
@@ -199,7 +199,7 @@
// SiteInstance.
NavigateActiveAndCommit(kNtpUrl);
- contents2.controller().LoadURL(
+ contents2.GetController().LoadURL(
kNtpUrl, content::Referrer(), content::PAGE_TRANSITION_LINK,
std::string());
dest_rvh2->SendShouldCloseACK(true);
@@ -292,7 +292,7 @@
TestTabContents tab_contents(browser_context(), instance);
notifications.ListenFor(
content::NOTIFICATION_RENDER_VIEW_HOST_CHANGED,
- content::Source<NavigationController>(&tab_contents.controller()));
+ content::Source<NavigationController>(&tab_contents.GetController()));
// Create.
RenderViewHostManager manager(&tab_contents, &tab_contents);
@@ -380,7 +380,7 @@
TestTabContents tab_contents(browser_context(), instance);
notifications.ListenFor(
content::NOTIFICATION_RENDER_VIEW_HOST_CHANGED,
- content::Source<NavigationController>(&tab_contents.controller()));
+ content::Source<NavigationController>(&tab_contents.GetController()));
// Create.
RenderViewHostManager manager(&tab_contents, &tab_contents);
@@ -610,7 +610,7 @@
EXPECT_EQ(evil_rvh, contents()->render_manager_for_testing()->current_host());
// Also we should not have a pending navigation entry.
- NavigationEntry* entry = contents()->controller().GetActiveEntry();
+ NavigationEntry* entry = contents()->GetController().GetActiveEntry();
ASSERT_TRUE(entry != NULL);
EXPECT_EQ(kUrl2, entry->url());
}
« no previous file with comments | « content/browser/tab_contents/navigation_controller_unittest.cc ('k') | content/browser/tab_contents/tab_contents.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698