Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1542)

Unified Diff: content/browser/tab_contents/tab_contents.h

Issue 8956050: Rename TabContents::controller() to GetController and put it into the WebContents interface. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/tab_contents/tab_contents.h
===================================================================
--- content/browser/tab_contents/tab_contents.h (revision 115228)
+++ content/browser/tab_contents/tab_contents.h (working copy)
@@ -87,31 +87,15 @@
// Intrinsic tab state -------------------------------------------------------
- // Gets the controller for this tab contents.
- NavigationController& controller() { return controller_; }
- const NavigationController& controller() const { return controller_; }
-
// Returns the user browser context associated with this TabContents (via the
// NavigationController).
content::BrowserContext* browser_context() const {
return controller_.browser_context();
}
- // Allows overriding the type of this tab.
- void set_view_type(content::ViewType type) { view_type_ = type; }
-
// Returns the SavePackage which manages the page saving job. May be NULL.
SavePackage* save_package() const { return save_package_.get(); }
- // Return the currently active RenderProcessHost and RenderViewHost. Each of
- // these may change over time.
- content::RenderProcessHost* GetRenderProcessHost() const;
-
-
-
-
-
-
WebUI* committed_web_ui() const {
return render_manager_.web_ui();
}
@@ -480,8 +464,11 @@
virtual base::PropertyBag* GetPropertyBag() OVERRIDE;
virtual content::WebContentsDelegate* GetDelegate() OVERRIDE;
virtual void SetDelegate(content::WebContentsDelegate* delegate) OVERRIDE;
-
-
+ virtual NavigationController& GetController() OVERRIDE;
+ virtual const NavigationController& GetController() const OVERRIDE;
+ // TODO(jam): browser_context getters go here
+ virtual void SetViewType(content::ViewType type) OVERRIDE;
+ virtual content::RenderProcessHost* GetRenderProcessHost() const OVERRIDE;
virtual RenderViewHost* GetRenderViewHost() const OVERRIDE;
« no previous file with comments | « content/browser/tab_contents/render_view_host_manager_unittest.cc ('k') | content/browser/tab_contents/tab_contents.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698