Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6377)

Unified Diff: chrome/browser/ui/browser_browsertest.cc

Issue 8956050: Rename TabContents::controller() to GetController and put it into the WebContents interface. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/browser_navigator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_browsertest.cc
===================================================================
--- chrome/browser/ui/browser_browsertest.cc (revision 115228)
+++ chrome/browser/ui/browser_browsertest.cc (working copy)
@@ -383,9 +383,9 @@
EXPECT_TRUE(newtab);
EXPECT_NE(oldtab, newtab);
nav_observer.Wait();
- ASSERT_TRUE(newtab->controller().GetLastCommittedEntry());
+ ASSERT_TRUE(newtab->GetController().GetLastCommittedEntry());
EXPECT_EQ(https_url.spec(),
- newtab->controller().GetLastCommittedEntry()->url().spec());
+ newtab->GetController().GetLastCommittedEntry()->url().spec());
// Popup window should not be in the opener's process.
content::RenderProcessHost* popup_process =
@@ -417,9 +417,9 @@
EXPECT_TRUE(newtab2);
EXPECT_NE(oldtab, newtab2);
nav_observer2.Wait();
- ASSERT_TRUE(newtab2->controller().GetLastCommittedEntry());
+ ASSERT_TRUE(newtab2->GetController().GetLastCommittedEntry());
EXPECT_EQ(https_url.spec(),
- newtab2->controller().GetLastCommittedEntry()->url().spec());
+ newtab2->GetController().GetLastCommittedEntry()->url().spec());
// This popup window should also not be in the opener's process.
content::RenderProcessHost* popup_process2 =
@@ -470,9 +470,9 @@
EXPECT_TRUE(newtab);
EXPECT_NE(oldtab, newtab);
nav_observer.Wait();
- ASSERT_TRUE(newtab->controller().GetLastCommittedEntry());
+ ASSERT_TRUE(newtab->GetController().GetLastCommittedEntry());
EXPECT_EQ(https_url.spec(),
- newtab->controller().GetLastCommittedEntry()->url().spec());
+ newtab->GetController().GetLastCommittedEntry()->url().spec());
// Popup window should still be in the opener's process.
content::RenderProcessHost* popup_process =
@@ -490,9 +490,9 @@
oldtab->GetRenderViewHost()->
ExecuteJavascriptInWebFrame(string16(), ASCIIToUTF16(navigate_str));
nav_observer2.Wait();
- ASSERT_TRUE(oldtab->controller().GetLastCommittedEntry());
+ ASSERT_TRUE(oldtab->GetController().GetLastCommittedEntry());
EXPECT_EQ(https_url.spec(),
- oldtab->controller().GetLastCommittedEntry()->url().spec());
+ oldtab->GetController().GetLastCommittedEntry()->url().spec());
// Original window should still be in the original process.
content::RenderProcessHost* new_process = newtab->GetRenderProcessHost();
@@ -647,7 +647,7 @@
ui_test_utils::NavigateToURL(browser(), url);
NavigationEntry* entry = browser()->GetSelectedTabContents()->
- controller().GetActiveEntry();
+ GetController().GetActiveEntry();
EXPECT_EQ(expected_favicon_url.spec(), entry->favicon().url().spec());
}
@@ -667,7 +667,7 @@
ui_test_utils::NavigateToURL(browser(), file_url);
NavigationEntry* entry = browser()->GetSelectedTabContents()->
- controller().GetActiveEntry();
+ GetController().GetActiveEntry();
static const FilePath::CharType* kIcon =
FILE_PATH_LITERAL("test1.png");
GURL expected_favicon_url(
@@ -1136,7 +1136,7 @@
ui_test_utils::WindowedNotificationObserver back_nav_load_observer(
content::NOTIFICATION_LOAD_STOP,
content::Source<NavigationController>(
- &browser()->GetSelectedTabContents()->controller()));
+ &browser()->GetSelectedTabContents()->GetController()));
browser()->GoBack(CURRENT_TAB);
back_nav_load_observer.Wait();
EXPECT_TRUE(browser()->command_updater()->IsCommandEnabled(IDC_FORWARD));
@@ -1144,7 +1144,7 @@
ui_test_utils::WindowedNotificationObserver forward_nav_load_observer(
content::NOTIFICATION_LOAD_STOP,
content::Source<NavigationController>(
- &browser()->GetSelectedTabContents()->controller()));
+ &browser()->GetSelectedTabContents()->GetController()));
browser()->GoForward(CURRENT_TAB);
// This check will happen before the navigation completes, since the browser
// won't process the renderer's response until the Wait() call below.
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/browser_navigator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698