Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8603015: Get rid of a bunch of view_messages.h includes from chrome by making the TabContentsObserver inte... (Closed)

Created:
9 years, 1 month ago by jam
Modified:
9 years, 1 month ago
Reviewers:
Jói
CC:
chromium-reviews, GeorgeY, Avi (use Gerrit), creis+watch_chromium.org, cbentzel+watch_chromium.org, tburkard+watch_chromium.org, Erik does not do reviews, ajwong+watch_chromium.org, mihaip+watch_chromium.org, dpranke-watch+content_chromium.org, Aaron Boodman, dominich+watch_chromium.org, darin-cc_chromium.org, dyu1, brettw-cc_chromium.org, Ilya Sherman, mmenke, dhollowa
Visibility:
Public.

Description

Get rid of a bunch of view_messages.h includes from chrome by making the TabContentsObserver interface not use a struct from it. Instead, the interface uses a new struct, content::FrameNavigateParams, that's in the public directory. The IPC message's struct derives from it. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110963

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : Add IPC macros for defining a struct that has a parent #

Patch Set 4 : fix ipclist and mac build errors #

Patch Set 5 : fix linux and try to fix mac again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -150 lines) Patch
M chrome/browser/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/tab_specific_content_settings.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/tab_specific_content_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_tab_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/external_tab_container_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/favicon/favicon_tab_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/favicon/favicon_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history_tab_helper.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/history/history_tab_helper.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/password_manager/password_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.h View 3 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/tabs/tab_finder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tabs/tab_finder.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/translate/translate_tab_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/blocked_content/blocked_content_tab_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/blocked_content/blocked_content_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_tab_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/applescript/tab_applescript.mm View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/constrained_window_tab_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/constrained_window_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/search_engines/search_engine_tab_helper.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/search_engines/search_engine_tab_helper.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/tools/ipclist/ipcfuzz.cc View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/intents/intent_injector.h View 2 chunks +2 lines, -9 lines 0 comments Download
M content/browser/intents/intent_injector.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents_observer.h View 2 chunks +6 lines, -3 lines 0 comments Download
M content/browser/tab_contents/tab_contents_observer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/view_messages.h View 1 2 10 chunks +51 lines, -77 lines 0 comments Download
M content/content_common.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
A content/public/common/frame_navigate_params.h View 1 chunk +67 lines, -0 lines 0 comments Download
A content/public/common/frame_navigate_params.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M ipc/ipc_message_macros.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M ipc/ipc_message_null_macros.h View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M ipc/param_traits_log_macros.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M ipc/param_traits_read_macros.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M ipc/param_traits_write_macros.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M ipc/struct_constructor_macros.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M ipc/struct_destructor_macros.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
9 years, 1 month ago (2011-11-20 02:46:05 UTC) #1
Jói
9 years, 1 month ago (2011-11-20 19:05:05 UTC) #2 
LGTM
cool!

Powered by Google App Engine
This is Rietveld 408576698