Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Side by Side Diff: chrome/browser/favicon/favicon_tab_helper.h

Issue 8603015: Get rid of a bunch of view_messages.h includes from chrome by making the TabContentsObserver inte... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix linux and try to fix mac again Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_FAVICON_FAVICON_TAB_HELPER_H_ 5 #ifndef CHROME_BROWSER_FAVICON_FAVICON_TAB_HELPER_H_
6 #define CHROME_BROWSER_FAVICON_FAVICON_TAB_HELPER_H_ 6 #define CHROME_BROWSER_FAVICON_FAVICON_TAB_HELPER_H_
7 #pragma once 7 #pragma once
8 8
9 #include <vector> 9 #include <vector>
10 10
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 virtual void StartDownload(int id, const GURL& url, int image_size) OVERRIDE; 78 virtual void StartDownload(int id, const GURL& url, int image_size) OVERRIDE;
79 virtual void NotifyFaviconUpdated() OVERRIDE; 79 virtual void NotifyFaviconUpdated() OVERRIDE;
80 80
81 private: 81 private:
82 // TabContentsObserver overrides. 82 // TabContentsObserver overrides.
83 virtual void NavigateToPendingEntry( 83 virtual void NavigateToPendingEntry(
84 const GURL& url, 84 const GURL& url,
85 NavigationController::ReloadType reload_type) OVERRIDE; 85 NavigationController::ReloadType reload_type) OVERRIDE;
86 virtual void DidNavigateMainFrame( 86 virtual void DidNavigateMainFrame(
87 const content::LoadCommittedDetails& details, 87 const content::LoadCommittedDetails& details,
88 const ViewHostMsg_FrameNavigate_Params& params) OVERRIDE; 88 const content::FrameNavigateParams& params) OVERRIDE;
89 virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; 89 virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
90 90
91 void OnDidDownloadFavicon(int id, 91 void OnDidDownloadFavicon(int id,
92 const GURL& image_url, 92 const GURL& image_url,
93 bool errored, 93 bool errored,
94 const SkBitmap& image); 94 const SkBitmap& image);
95 95
96 Profile* profile_; 96 Profile* profile_;
97 97
98 scoped_ptr<FaviconHandler> favicon_handler_; 98 scoped_ptr<FaviconHandler> favicon_handler_;
99 99
100 // Handles downloading touchicons. It is NULL if 100 // Handles downloading touchicons. It is NULL if
101 // browser_defaults::kEnableTouchIcon is false. 101 // browser_defaults::kEnableTouchIcon is false.
102 scoped_ptr<FaviconHandler> touch_icon_handler_; 102 scoped_ptr<FaviconHandler> touch_icon_handler_;
103 103
104 DISALLOW_COPY_AND_ASSIGN(FaviconTabHelper); 104 DISALLOW_COPY_AND_ASSIGN(FaviconTabHelper);
105 }; 105 };
106 106
107 #endif // CHROME_BROWSER_FAVICON_FAVICON_TAB_HELPER_H_ 107 #endif // CHROME_BROWSER_FAVICON_FAVICON_TAB_HELPER_H_
OLDNEW
« no previous file with comments | « chrome/browser/external_tab_container_win.cc ('k') | chrome/browser/favicon/favicon_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698