Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: chrome/browser/ui/bookmarks/bookmark_tab_helper.cc

Issue 8603015: Get rid of a bunch of view_messages.h includes from chrome by making the TabContentsObserver inte... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix linux and try to fix mac again Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/bookmarks/bookmark_tab_helper.h" 5 #include "chrome/browser/ui/bookmarks/bookmark_tab_helper.h"
6 6
7 #include "chrome/browser/bookmarks/bookmark_model.h" 7 #include "chrome/browser/bookmarks/bookmark_model.h"
8 #include "chrome/browser/bookmarks/bookmark_node_data.h" 8 #include "chrome/browser/bookmarks/bookmark_node_data.h"
9 #include "chrome/browser/profiles/profile.h" 9 #include "chrome/browser/profiles/profile.h"
10 #include "chrome/browser/ui/bookmarks/bookmark_tab_helper_delegate.h" 10 #include "chrome/browser/ui/bookmarks/bookmark_tab_helper_delegate.h"
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 } 55 }
56 56
57 // When it's the first load, we know either the pending one or the committed 57 // When it's the first load, we know either the pending one or the committed
58 // one will have the Web UI in it (see GetWebUIForCurrentState), and only one 58 // one will have the Web UI in it (see GetWebUIForCurrentState), and only one
59 // of them will be valid, so we can just check both. 59 // of them will be valid, so we can just check both.
60 return CanShowBookmarkBar(tab_contents()->web_ui()); 60 return CanShowBookmarkBar(tab_contents()->web_ui());
61 } 61 }
62 62
63 void BookmarkTabHelper::DidNavigateMainFrame( 63 void BookmarkTabHelper::DidNavigateMainFrame(
64 const content::LoadCommittedDetails& /*details*/, 64 const content::LoadCommittedDetails& /*details*/,
65 const ViewHostMsg_FrameNavigate_Params& /*params*/) { 65 const content::FrameNavigateParams& /*params*/) {
66 UpdateStarredStateForCurrentURL(); 66 UpdateStarredStateForCurrentURL();
67 } 67 }
68 68
69 void BookmarkTabHelper::Observe(int type, 69 void BookmarkTabHelper::Observe(int type,
70 const content::NotificationSource& source, 70 const content::NotificationSource& source,
71 const content::NotificationDetails& details) { 71 const content::NotificationDetails& details) {
72 switch (type) { 72 switch (type) {
73 case chrome::NOTIFICATION_BOOKMARK_MODEL_LOADED: 73 case chrome::NOTIFICATION_BOOKMARK_MODEL_LOADED:
74 // BookmarkModel finished loading, fall through to update starred state. 74 // BookmarkModel finished loading, fall through to update starred state.
75 case chrome::NOTIFICATION_URLS_STARRED: { 75 case chrome::NOTIFICATION_URLS_STARRED: {
(...skipping 26 matching lines...) Expand all
102 void BookmarkTabHelper::UpdateStarredStateForCurrentURL() { 102 void BookmarkTabHelper::UpdateStarredStateForCurrentURL() {
103 Profile* profile = 103 Profile* profile =
104 Profile::FromBrowserContext(tab_contents()->browser_context()); 104 Profile::FromBrowserContext(tab_contents()->browser_context());
105 BookmarkModel* model = profile->GetBookmarkModel(); 105 BookmarkModel* model = profile->GetBookmarkModel();
106 const bool old_state = is_starred_; 106 const bool old_state = is_starred_;
107 is_starred_ = (model && model->IsBookmarked(tab_contents()->GetURL())); 107 is_starred_ = (model && model->IsBookmarked(tab_contents()->GetURL()));
108 108
109 if (is_starred_ != old_state && delegate()) 109 if (is_starred_ != old_state && delegate())
110 delegate()->URLStarredChanged(tab_contents_wrapper_, is_starred_); 110 delegate()->URLStarredChanged(tab_contents_wrapper_, is_starred_);
111 } 111 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/bookmarks/bookmark_tab_helper.h ('k') | chrome/browser/ui/cocoa/applescript/tab_applescript.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698