Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Unified Diff: chrome/browser/history/history_tab_helper.cc

Issue 8603015: Get rid of a bunch of view_messages.h includes from chrome by making the TabContentsObserver inte... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix linux and try to fix mac again Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/history_tab_helper.h ('k') | chrome/browser/password_manager/password_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_tab_helper.cc
===================================================================
--- chrome/browser/history/history_tab_helper.cc (revision 110851)
+++ chrome/browser/history/history_tab_helper.cc (working copy)
@@ -13,10 +13,11 @@
#include "content/browser/tab_contents/tab_contents.h"
#include "content/browser/tab_contents/tab_contents_delegate.h"
#include "content/browser/tab_contents/title_updated_details.h"
-#include "content/common/view_messages.h"
#include "content/public/browser/notification_details.h"
#include "content/public/browser/notification_source.h"
#include "content/public/browser/notification_types.h"
+#include "content/public/browser/notification_details.h"
+#include "content/public/common/frame_navigate_params.h"
HistoryTabHelper::HistoryTabHelper(TabContents* tab_contents)
: TabContentsObserver(tab_contents),
@@ -45,7 +46,7 @@
HistoryTabHelper::CreateHistoryAddPageArgs(
const GURL& virtual_url,
const content::LoadCommittedDetails& details,
- const ViewHostMsg_FrameNavigate_Params& params) {
+ const content::FrameNavigateParams& params) {
scoped_refptr<history::HistoryAddPageArgs> add_page_args(
new history::HistoryAddPageArgs(
params.url, base::Time::Now(), tab_contents(), params.page_id,
@@ -79,14 +80,14 @@
void HistoryTabHelper::DidNavigateMainFrame(
const content::LoadCommittedDetails& details,
- const ViewHostMsg_FrameNavigate_Params& params) {
+ const content::FrameNavigateParams& params) {
// Allow the new page to set the title again.
received_page_title_ = false;
}
void HistoryTabHelper::DidNavigateAnyFrame(
const content::LoadCommittedDetails& details,
- const ViewHostMsg_FrameNavigate_Params& params) {
+ const content::FrameNavigateParams& params) {
// Update history. Note that this needs to happen after the entry is complete,
// which WillNavigate[Main,Sub]Frame will do before this function is called.
if (!params.should_update_history)
« no previous file with comments | « chrome/browser/history/history_tab_helper.h ('k') | chrome/browser/password_manager/password_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698