Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Side by Side Diff: chrome/browser/tabs/tab_finder.cc

Issue 8603015: Get rid of a bunch of view_messages.h includes from chrome by making the TabContentsObserver inte... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix linux and try to fix mac again Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/tabs/tab_finder.h ('k') | chrome/browser/translate/translate_tab_helper.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/tabs/tab_finder.h" 5 #include "chrome/browser/tabs/tab_finder.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/stl_util.h" 10 #include "base/stl_util.h"
11 #include "chrome/browser/history/history.h" 11 #include "chrome/browser/history/history.h"
12 #include "chrome/browser/profiles/profile.h" 12 #include "chrome/browser/profiles/profile.h"
13 #include "chrome/browser/ui/browser.h" 13 #include "chrome/browser/ui/browser.h"
14 #include "chrome/browser/ui/browser_list.h" 14 #include "chrome/browser/ui/browser_list.h"
15 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" 15 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
16 #include "chrome/common/chrome_switches.h" 16 #include "chrome/common/chrome_switches.h"
17 #include "content/browser/tab_contents/navigation_details.h" 17 #include "content/browser/tab_contents/navigation_details.h"
18 #include "content/browser/tab_contents/navigation_entry.h" 18 #include "content/browser/tab_contents/navigation_entry.h"
19 #include "content/browser/tab_contents/tab_contents.h" 19 #include "content/browser/tab_contents/tab_contents.h"
20 #include "content/browser/tab_contents/tab_contents_observer.h" 20 #include "content/browser/tab_contents/tab_contents_observer.h"
21 #include "content/public/browser/notification_service.h" 21 #include "content/public/browser/notification_service.h"
22 #include "content/common/view_messages.h"
23 #include "content/public/browser/notification_source.h" 22 #include "content/public/browser/notification_source.h"
24 #include "content/public/browser/notification_types.h" 23 #include "content/public/browser/notification_types.h"
24 #include "content/public/common/frame_navigate_params.h"
25 #include "content/public/common/page_transition_types.h" 25 #include "content/public/common/page_transition_types.h"
26 26
27 class TabFinder::TabContentsObserverImpl : public TabContentsObserver { 27 class TabFinder::TabContentsObserverImpl : public TabContentsObserver {
28 public: 28 public:
29 TabContentsObserverImpl(TabContents* tab, TabFinder* finder); 29 TabContentsObserverImpl(TabContents* tab, TabFinder* finder);
30 virtual ~TabContentsObserverImpl(); 30 virtual ~TabContentsObserverImpl();
31 31
32 TabContents* tab_contents() { return TabContentsObserver::tab_contents(); } 32 TabContents* tab_contents() { return TabContentsObserver::tab_contents(); }
33 33
34 // TabContentsObserver overrides: 34 // TabContentsObserver overrides:
35 virtual void DidNavigateAnyFrame( 35 virtual void DidNavigateAnyFrame(
36 const content::LoadCommittedDetails& details, 36 const content::LoadCommittedDetails& details,
37 const ViewHostMsg_FrameNavigate_Params& params) OVERRIDE; 37 const content::FrameNavigateParams& params) OVERRIDE;
38 virtual void TabContentsDestroyed(TabContents* tab) OVERRIDE; 38 virtual void TabContentsDestroyed(TabContents* tab) OVERRIDE;
39 39
40 private: 40 private:
41 TabFinder* finder_; 41 TabFinder* finder_;
42 42
43 DISALLOW_COPY_AND_ASSIGN(TabContentsObserverImpl); 43 DISALLOW_COPY_AND_ASSIGN(TabContentsObserverImpl);
44 }; 44 };
45 45
46 TabFinder::TabContentsObserverImpl::TabContentsObserverImpl( 46 TabFinder::TabContentsObserverImpl::TabContentsObserverImpl(
47 TabContents* tab, 47 TabContents* tab,
48 TabFinder* finder) 48 TabFinder* finder)
49 : TabContentsObserver(tab), 49 : TabContentsObserver(tab),
50 finder_(finder) { 50 finder_(finder) {
51 } 51 }
52 52
53 TabFinder::TabContentsObserverImpl::~TabContentsObserverImpl() { 53 TabFinder::TabContentsObserverImpl::~TabContentsObserverImpl() {
54 } 54 }
55 55
56 void TabFinder::TabContentsObserverImpl::DidNavigateAnyFrame( 56 void TabFinder::TabContentsObserverImpl::DidNavigateAnyFrame(
57 const content::LoadCommittedDetails& details, 57 const content::LoadCommittedDetails& details,
58 const ViewHostMsg_FrameNavigate_Params& params) { 58 const content::FrameNavigateParams& params) {
59 finder_->DidNavigateAnyFrame(tab_contents(), details, params); 59 finder_->DidNavigateAnyFrame(tab_contents(), details, params);
60 } 60 }
61 61
62 void TabFinder::TabContentsObserverImpl::TabContentsDestroyed( 62 void TabFinder::TabContentsObserverImpl::TabContentsDestroyed(
63 TabContents* tab) { 63 TabContents* tab) {
64 finder_->TabDestroyed(this); 64 finder_->TabDestroyed(this);
65 delete this; 65 delete this;
66 } 66 }
67 67
68 // static 68 // static
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 content::NotificationService::AllSources()); 126 content::NotificationService::AllSources());
127 } 127 }
128 128
129 TabFinder::~TabFinder() { 129 TabFinder::~TabFinder() {
130 STLDeleteElements(&tab_contents_observers_); 130 STLDeleteElements(&tab_contents_observers_);
131 } 131 }
132 132
133 void TabFinder::DidNavigateAnyFrame( 133 void TabFinder::DidNavigateAnyFrame(
134 TabContents* source, 134 TabContents* source,
135 const content::LoadCommittedDetails& details, 135 const content::LoadCommittedDetails& details,
136 const ViewHostMsg_FrameNavigate_Params& params) { 136 const content::FrameNavigateParams& params) {
137 CancelRequestsFor(source); 137 CancelRequestsFor(source);
138 138
139 if (content::PageTransitionIsRedirect(params.transition)) { 139 if (content::PageTransitionIsRedirect(params.transition)) {
140 // If this is a redirect, we need to go to the db to get the start. 140 // If this is a redirect, we need to go to the db to get the start.
141 FetchRedirectStart(source); 141 FetchRedirectStart(source);
142 } else if (params.redirects.size() > 1 || 142 } else if (params.redirects.size() > 1 ||
143 params.redirects[0] != details.entry->url()) { 143 params.redirects[0] != details.entry->url()) {
144 tab_contents_to_url_[source] = params.redirects[0]; 144 tab_contents_to_url_[source] = params.redirects[0];
145 } 145 }
146 } 146 }
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 GURL url, 228 GURL url,
229 bool success, 229 bool success,
230 history::RedirectList* redirects) { 230 history::RedirectList* redirects) {
231 if (success && !redirects->empty()) { 231 if (success && !redirects->empty()) {
232 TabContents* tab_contents = 232 TabContents* tab_contents =
233 callback_consumer_.GetClientDataForCurrentRequest(); 233 callback_consumer_.GetClientDataForCurrentRequest();
234 DCHECK(tab_contents); 234 DCHECK(tab_contents);
235 tab_contents_to_url_[tab_contents] = redirects->back(); 235 tab_contents_to_url_[tab_contents] = redirects->back();
236 } 236 }
237 } 237 }
OLDNEW
« no previous file with comments | « chrome/browser/tabs/tab_finder.h ('k') | chrome/browser/translate/translate_tab_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698