Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: content/browser/tab_contents/tab_contents_observer.cc

Issue 8603015: Get rid of a bunch of view_messages.h includes from chrome by making the TabContentsObserver inte... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix linux and try to fix mac again Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « content/browser/tab_contents/tab_contents_observer.h ('k') | content/common/view_messages.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/tab_contents/tab_contents_observer.h" 5 #include "content/browser/tab_contents/tab_contents_observer.h"
6 6
7 #include "content/browser/renderer_host/render_view_host.h" 7 #include "content/browser/renderer_host/render_view_host.h"
8 #include "content/browser/tab_contents/navigation_details.h" 8 #include "content/browser/tab_contents/navigation_details.h"
9 #include "content/browser/tab_contents/tab_contents.h" 9 #include "content/browser/tab_contents/tab_contents.h"
10 10
11 void TabContentsObserver::RenderViewCreated(RenderViewHost* render_view_host) { 11 void TabContentsObserver::RenderViewCreated(RenderViewHost* render_view_host) {
12 } 12 }
13 13
14 void TabContentsObserver::RenderViewDeleted(RenderViewHost* render_view_host) { 14 void TabContentsObserver::RenderViewDeleted(RenderViewHost* render_view_host) {
15 } 15 }
16 16
17 void TabContentsObserver::RenderViewReady() { 17 void TabContentsObserver::RenderViewReady() {
18 } 18 }
19 19
20 void TabContentsObserver::RenderViewGone(base::TerminationStatus status) { 20 void TabContentsObserver::RenderViewGone(base::TerminationStatus status) {
21 } 21 }
22 22
23 void TabContentsObserver::NavigateToPendingEntry( 23 void TabContentsObserver::NavigateToPendingEntry(
24 const GURL& url, 24 const GURL& url,
25 NavigationController::ReloadType reload_type) { 25 NavigationController::ReloadType reload_type) {
26 } 26 }
27 27
28 void TabContentsObserver::DidNavigateMainFrame( 28 void TabContentsObserver::DidNavigateMainFrame(
29 const content::LoadCommittedDetails& details, 29 const content::LoadCommittedDetails& details,
30 const ViewHostMsg_FrameNavigate_Params& params) { 30 const content::FrameNavigateParams& params) {
31 } 31 }
32 32
33 void TabContentsObserver::DidNavigateAnyFrame( 33 void TabContentsObserver::DidNavigateAnyFrame(
34 const content::LoadCommittedDetails& details, 34 const content::LoadCommittedDetails& details,
35 const ViewHostMsg_FrameNavigate_Params& params) { 35 const content::FrameNavigateParams& params) {
36 } 36 }
37 37
38 void TabContentsObserver::DidStartProvisionalLoadForFrame( 38 void TabContentsObserver::DidStartProvisionalLoadForFrame(
39 int64 frame_id, 39 int64 frame_id,
40 bool is_main_frame, 40 bool is_main_frame,
41 const GURL& validated_url, 41 const GURL& validated_url,
42 bool is_error_page, 42 bool is_error_page,
43 RenderViewHost* render_view_host) { 43 RenderViewHost* render_view_host) {
44 } 44 }
45 45
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 } 156 }
157 157
158 void TabContentsObserver::TabContentsDestroyed() { 158 void TabContentsObserver::TabContentsDestroyed() {
159 // Do cleanup so that 'this' can safely be deleted from 159 // Do cleanup so that 'this' can safely be deleted from
160 // TabContentsDestroyed. 160 // TabContentsDestroyed.
161 tab_contents_->RemoveObserver(this); 161 tab_contents_->RemoveObserver(this);
162 TabContents* tab = tab_contents_; 162 TabContents* tab = tab_contents_;
163 tab_contents_ = NULL; 163 tab_contents_ = NULL;
164 TabContentsDestroyed(tab); 164 TabContentsDestroyed(tab);
165 } 165 }
OLDNEW
« no previous file with comments | « content/browser/tab_contents/tab_contents_observer.h ('k') | content/common/view_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698