chrome/browser/favicon/favicon_tab_helper.h - Issue 8603015: Get rid of a bunch of view_messages.h includes from chrome by making the TabContentsObserver inte...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/favicon/favicon_tab_helper.h

Issue 8603015: Get rid of a bunch of view_messages.h includes from chrome by making the TabContentsObserver inte... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: fix linux and try to fix mac again Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/favicon/favicon_tab_helper.h

===================================================================

--- chrome/browser/favicon/favicon_tab_helper.h (revision 110851)

+++ chrome/browser/favicon/favicon_tab_helper.h (working copy)

@@ -85,7 +85,7 @@

NavigationController::ReloadType reload_type) OVERRIDE;

virtual void DidNavigateMainFrame(

const content::LoadCommittedDetails& details,

- const ViewHostMsg_FrameNavigate_Params& params) OVERRIDE;

+ const content::FrameNavigateParams& params) OVERRIDE;

virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;

void OnDidDownloadFavicon(int id,

« no previous file with comments | « chrome/browser/external_tab_container_win.cc ('k') | chrome/browser/favicon/favicon_tab_helper.cc » ('j') | no next file with comments »