Issue 8253002: Move PageTransition into content namespace. While I'm touching all these files, I've also updated...

Issue 8253002: Move PageTransition into content namespace. While I'm touching all these files, I've also updated... (Closed)

Created:
9 years, 2 months ago by jam

Modified:
9 years, 2 months ago

Reviewers:
Jói

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Move PageTransition into content namespace. While I'm touching all these files, I've also updated it to use the enum naming convention in the Content API. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105254

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1759 lines, -1699 lines)			Patch
M	chrome/browser/accessibility/accessibility_win_browsertest.cc	View		9 chunks	+18 lines, -9 lines	0 comments	Download
M	chrome/browser/accessibility/renderer_accessibility_browsertest.cc	View		9 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/alternate_nav_url_fetcher.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/autocomplete.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_browsertest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit.cc	View		6 chunks	+11 lines, -9 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_match.h	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_match.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_popup_model.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_popup_model_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/history_contents_provider_unittest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/autocomplete/history_url_provider_unittest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/autocomplete/keyword_provider.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/search_provider.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/automation/automation_provider_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/automation/testing_automation_provider.cc	View		5 chunks	+8 lines, -5 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_context_menu_controller_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/bookmarks/bookmark_model_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/bookmarks/bookmark_utils.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/browser_commands_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/browser_focus_uitest.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/browsing_data_remover_unittest.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/bug_report_util.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/registration_screen.h	View		1 chunk	+6 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/login/registration_screen.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/media/media_player.cc	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/offline/offline_load_page_unittest.cc	View		3 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/panels/panel_browsertest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/tab_closeable_state_watcher_browsertest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/crash_recovery_browsertest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/custom_handlers/register_protocol_handler_infobar_delegate.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/debugger/devtools_window.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/debugger/devtools_window.cc	View		4 chunks	+10 lines, -8 lines	0 comments	Download
M	chrome/browser/download/chrome_download_manager_delegate.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/download/download_browsertest.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/download/download_request_limiter.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_context_menu_model.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_history_api.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_host.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_process_manager.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_tabs_module.cc	View		4 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/extension_web_ui.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_webnavigation_api.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_webnavigation_api.cc	View		3 chunks	+10 lines, -9 lines	0 comments	Download
M	chrome/browser/extensions/extension_webstore_private_api.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/file_manager_util.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/user_script_listener_unittest.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/webstore_inline_installer.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/window_open_apitest.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/external_tab_container_win.h	View		2 chunks	+11 lines, -9 lines	0 comments	Download
M	chrome/browser/external_tab_container_win.cc	View		7 chunks	+9 lines, -7 lines	0 comments	Download
M	chrome/browser/geolocation/chrome_geolocation_permission_context.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/google/google_url_tracker.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/history/expire_history_backend.cc	View		3 chunks	+16 lines, -16 lines	0 comments	Download
M	chrome/browser/history/expire_history_backend_unittest.cc	View		2 chunks	+6 lines, -5 lines	0 comments	Download
M	chrome/browser/history/history.h	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/history/history.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/history/history_backend.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/history/history_backend.cc	View		12 chunks	+50 lines, -35 lines	0 comments	Download
M	chrome/browser/history/history_backend_unittest.cc	View		12 chunks	+49 lines, -33 lines	0 comments	Download
M	chrome/browser/history/history_notifications.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/history/history_notifications.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/history/history_querying_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/history/history_tab_helper.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/history/history_types.h	View		6 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/history/history_types.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/history/history_unittest.cc	View		22 chunks	+30 lines, -27 lines	0 comments	Download
M	chrome/browser/history/in_memory_history_backend.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/history/text_database_manager_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/history/top_sites_unittest.cc	View		3 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/history/visit_database.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/history/visit_database.cc	View		7 chunks	+15 lines, -15 lines	0 comments	Download
M	chrome/browser/history/visit_database_unittest.cc	View	1 2 3 4	11 chunks	+35 lines, -27 lines	0 comments	Download
M	chrome/browser/importer/importer_host.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/infobars/infobar_delegate.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/instant/instant_controller.h	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/instant/instant_controller.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/instant/instant_loader.h	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/instant/instant_loader.cc	View		5 chunks	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/metrics/metrics_log.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/metrics/metrics_log_unittest.cc	View		2 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/net/gaia/gaia_oauth_fetcher.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/oom_priority_manager_browsertest.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/pdf_unsupported_feature.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/platform_util_chromeos.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/plugin_installer_infobar_delegate.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/plugin_observer.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/prerender/prerender_browsertest.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/prerender/prerender_contents.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/printing/print_preview_tab_controller.cc	View		4 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/printing/print_preview_tab_controller_browsertest.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/printing/print_preview_tab_controller_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/rlz/rlz.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/rlz/rlz_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/safe_browsing/browser_feature_extractor.cc	View		3 chunks	+7 lines, -6 lines	0 comments	Download
M	chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc	View		8 chunks	+19 lines, -16 lines	0 comments	Download
M	chrome/browser/safe_browsing/malware_details_unittest.cc	View		9 chunks	+17 lines, -16 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_blocking_page.cc	View		3 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc	View		8 chunks	+9 lines, -8 lines	0 comments	Download
M	chrome/browser/search_engines/template_url_service.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/search_engines/template_url_service_unittest.cc	View		4 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/sessions/session_restore.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sessions/session_restore_browsertest.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/sessions/session_service_unittest.cc	View		15 chunks	+24 lines, -22 lines	0 comments	Download
M	chrome/browser/sessions/session_types.h	View		4 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/sessions/session_types.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/sessions/session_utils_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sidebar/sidebar_container.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ssl/ssl_browser_tests.cc	View		5 chunks	+7 lines, -5 lines	0 comments	Download
M	chrome/browser/sync/glue/session_model_associator.cc	View		3 chunks	+32 lines, -32 lines	0 comments	Download
M	chrome/browser/sync/glue/session_model_associator_unittest.cc	View		5 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/sync/glue/synced_session_tracker_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/glue/typed_url_change_processor.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/sync/glue/typed_url_model_associator.cc	View		8 chunks	+22 lines, -17 lines	0 comments	Download
M	chrome/browser/sync/glue/typed_url_model_associator_unittest.cc	View		11 chunks	+31 lines, -31 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_session_unittest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/sync/profile_sync_service_typed_url_unittest.cc	View		8 chunks	+11 lines, -9 lines	0 comments	Download
M	chrome/browser/sync/test/integration/performance/sessions_sync_perf_test.cc	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/sync/test/integration/typed_urls_helper.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/tab_contents/background_contents.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/tab_contents/insecure_content_infobar_delegate.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/tab_contents/language_state.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_context_menu.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_context_menu.cc	View		11 chunks	+11 lines, -11 lines	0 comments	Download
M	chrome/browser/tab_contents/web_contents_unittest.cc	View		44 chunks	+106 lines, -75 lines	0 comments	Download
M	chrome/browser/tab_contents/web_drop_target_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/tabs/default_tab_handler.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/tabs/default_tab_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/tabs/pinned_tab_codec.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/tabs/tab_finder.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/tabs/tab_strip_model.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/tabs/tab_strip_model.cc	View		5 chunks	+11 lines, -11 lines	0 comments	Download
M	chrome/browser/tabs/tab_strip_model_delegate.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/tabs/tab_strip_model_order_controller.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/tabs/tab_strip_model_order_controller.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/tabs/tab_strip_model_unittest.cc	View		27 chunks	+55 lines, -52 lines	0 comments	Download
M	chrome/browser/task_manager/task_manager.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/task_manager/task_manager_browsertest.cc	View		6 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/translate/options_menu_model.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/translate/translate_manager.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/translate/translate_manager_browsertest.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/auto_login_prompter.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/blocked_content/blocked_content_container.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/blocked_content/blocked_content_container.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/browser.h	View		6 chunks	+18 lines, -16 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View		22 chunks	+30 lines, -26 lines	0 comments	Download
M	chrome/browser/ui/browser_browsertest.cc	View		15 chunks	+21 lines, -15 lines	0 comments	Download
M	chrome/browser/ui/browser_init.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/browser_navigator.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/browser_navigator.cc	View	1 2 3	5 chunks	+16 lines, -13 lines	0 comments	Download
M	chrome/browser/ui/browser_navigator_browsertest.cc	View	1 2 3	13 chunks	+31 lines, -18 lines	0 comments	Download
M	chrome/browser/ui/cocoa/about_window_controller.mm	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/applescript/tab_applescript.mm	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/applescript/window_applescript.mm	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_controller.mm	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/constrained_html_delegate_mac.mm	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/history_menu_bridge_unittest.mm	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/history_menu_cocoa_controller.mm	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/html_dialog_window_controller.mm	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm	View	1 2 3	3 chunks	+11 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/cocoa/page_info_bubble_controller.mm	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/tab_contents/web_drop_target.mm	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/tabs/tab_strip_controller_unittest.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/view_id_util_browsertest.mm	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/find_bar/find_bar_controller.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/find_bar/find_bar_host_browsertest.cc	View		4 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/gtk/about_chrome_dialog.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk_interactive_uitest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.cc	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/constrained_html_delegate_gtk.cc	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/global_bookmark_menu.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/global_history_menu.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/html_dialog_gtk.cc	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/instant_confirm_dialog_gtk.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/location_bar_view_gtk.h	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/gtk/location_bar_view_gtk.cc	View	1 2 3 4	5 chunks	+8 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/page_info_bubble_gtk.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/sad_tab_gtk.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.h	View		1 chunk	+6 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/gtk/view_id_util_browsertest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker_controller.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/login/login_prompt_browsertest.cc	View		8 chunks	+16 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/omnibox/location_bar.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/omnibox/omnibox_view.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/panels/base_panel_browser_test.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_browser_window_cocoa_unittest.mm	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/panels/panel_settings_menu_model.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/search_engines/search_engine_tab_helper.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/toolbar/toolbar_model_unittest.cc	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/views/about_chrome_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_context_menu_test.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/constrained_html_delegate_views.cc	View		1 chunk	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/views/dom_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/extensions/extension_install_dialog_view.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/find_bar_host_interactive_uitest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/instant_confirm_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/location_bar/location_bar_view.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/location_bar/location_bar_view.cc	View		3 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/views/omnibox/omnibox_view_views.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/omnibox/omnibox_view_win.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/page_info_bubble_view.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/sad_tab_view.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/tabs/dragged_tab_controller.h	View		1 chunk	+6 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/dragged_tab_controller.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/active_downloads_ui.cc	View	1 2 3	3 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/html_dialog_tab_contents_delegate.h	View		1 chunk	+6 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/webui/html_dialog_tab_contents_delegate.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/html_dialog_tab_contents_delegate_unittest.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/new_tab_ui.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/ntp/ntp_login_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options/advanced_options_handler.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/options/advanced_options_utils_x11.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/print_preview_handler.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/sync_promo_handler.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/web_ui_browsertest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/web_ui_unittest.cc	View		6 chunks	+11 lines, -8 lines	0 comments	Download
M	chrome/common/metrics_helpers.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/metrics_helpers.cc	View		2 chunks	+16 lines, -16 lines	0 comments	Download
M	chrome/renderer/safe_browsing/phishing_classifier_delegate.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/renderer/safe_browsing/phishing_classifier_delegate.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/test/base/browser_with_test_window_test.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/base/browser_with_test_window_test.cc	View		3 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/test/base/in_process_browser_test.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/test/base/in_process_browser_test.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/test/base/test_location_bar.h	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/test/base/test_location_bar.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/test/base/ui_test_utils.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/tools/profiles/generate_profile.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	content/browser/download/download_create_info.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	content/browser/download/download_create_info.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/download/download_state_info.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	content/browser/download/download_state_info.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	content/browser/download/mhtml_generation_manager.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/load_notification_details.h	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host_unittest.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/resource_dispatcher_host.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/resource_dispatcher_host_request_info.h	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	content/browser/renderer_host/resource_dispatcher_host_request_info.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/resource_dispatcher_host_unittest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/resource_queue_unittest.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/test_render_view_host.h	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	content/browser/renderer_host/test_render_view_host.cc	View		3 chunks	+4 lines, -3 lines	0 comments	Download
M	content/browser/site_instance_unittest.cc	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	content/browser/tab_contents/interstitial_page.cc	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/tab_contents/navigation_controller.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	content/browser/tab_contents/navigation_controller.cc	View		17 chunks	+27 lines, -22 lines	0 comments	Download
M	content/browser/tab_contents/navigation_controller_unittest.cc	View		55 chunks	+107 lines, -69 lines	0 comments	Download
M	content/browser/tab_contents/navigation_entry.h	View		4 chunks	+5 lines, -5 lines	0 comments	Download
M	content/browser/tab_contents/navigation_entry.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/tab_contents/navigation_entry_unittest.cc	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	content/browser/tab_contents/page_navigator.h	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	content/browser/tab_contents/page_navigator.cc	View		2 chunks	+5 lines, -3 lines	0 comments	Download
M	content/browser/tab_contents/provisional_load_details.h	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	content/browser/tab_contents/provisional_load_details.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/tab_contents/render_view_host_manager.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/tab_contents/render_view_host_manager_unittest.cc	View		14 chunks	+20 lines, -19 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/tab_contents/tab_contents.cc	View		7 chunks	+14 lines, -10 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents_delegate.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents_delegate.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents_delegate_unittest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/tab_contents/tab_contents_observer.h	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents_observer.cc	View		2 chunks	+9 lines, -8 lines	0 comments	Download
M	content/browser/tab_contents/test_tab_contents.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	content/browser/webui/generic_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/webui/web_ui.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	content/browser/webui/web_ui.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/common/common_param_traits.h	View		2 chunks	+6 lines, -0 lines	0 comments	Download
D	content/common/page_transition_types.h	View		1 chunk	+0 lines, -172 lines	0 comments	Download
D	content/common/page_transition_types.cc	View		1 chunk	+0 lines, -36 lines	0 comments	Download
M	content/common/request_extra_data.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	content/common/request_extra_data.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/common/resource_dispatcher.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/common/resource_dispatcher_unittest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	content/common/resource_messages.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/common/view_messages.h	View		3 chunks	+2 lines, -3 lines	0 comments	Download
M	content/content_common.gypi	View	1 2 3 4	2 chunks	+2 lines, -2 lines	0 comments	Download
A +	content/public/common/page_transition_types.h	View	1 2 3	1 chunk	+118 lines, -133 lines	0 comments	Download
A +	content/public/common/page_transition_types.cc	View	1 2 3	1 chunk	+46 lines, -20 lines	0 comments	Download
M	content/public/renderer/navigation_state.h	View		5 chunks	+8 lines, -8 lines	0 comments	Download
M	content/public/renderer/navigation_state.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/render_view_browsertest.cc	View		6 chunks	+6 lines, -6 lines	0 comments	Download
M	content/renderer/render_view_impl.cc	View		9 chunks	+14 lines, -12 lines	0 comments	Download
M	content/shell/shell.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/shell/shell_browser_main.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/test/render_view_fake_resources_test.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate_gtk.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jói

9 years, 2 months ago (2011-10-12 22:35:02 UTC) #2

LGTM

http://codereview.chromium.org/8253002/diff/8001/chrome/browser/ui/browser_na...
File chrome/browser/ui/browser_navigator.cc (right):

http://codereview.chromium.org/8253002/diff/8001/chrome/browser/ui/browser_na...
chrome/browser/ui/browser_navigator.cc:451: params->transition |
content::PAGE_TRANSITION_HOME_PAGE);
indent 2 more

http://codereview.chromium.org/8253002/diff/8001/chrome/browser/ui/browser_na...
File chrome/browser/ui/browser_navigator_browsertest.cc (right):

http://codereview.chromium.org/8253002/diff/8001/chrome/browser/ui/browser_na...
chrome/browser/ui/browser_navigator_browsertest.cc:773: GetGoogleURL(),
content::PAGE_TRANSITION_LINK);
indent 2 more

Expand Messages | Collapse Messages