chrome/browser/printing/print_preview_tab_controller_browsertest.cc - Issue 8253002: Move PageTransition into content namespace. While I'm touching all these files, I've also updated...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_preview_tab_controller_browsertest.cc

Issue 8253002: Move PageTransition into content namespace. While I'm touching all these files, I've also updated... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/printing/print_preview_tab_controller.cc ('k') | chrome/browser/printing/print_preview_tab_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/print_preview_tab_controller_browsertest.cc

===================================================================

--- chrome/browser/printing/print_preview_tab_controller_browsertest.cc (revision 105162)

+++ chrome/browser/printing/print_preview_tab_controller_browsertest.cc (working copy)

@@ -177,7 +177,7 @@

const int kTabCount = 4;

// Create kTabCount - 1 tabs since we start with 1 tab already.

for (int i = 0; i < kTabCount - 1; ++i) {

- browser::NavigateParams p(browser(), GURL(), PageTransition::LINK);

+ browser::NavigateParams p(browser(), GURL(), content::PAGE_TRANSITION_LINK);

p.disposition = NEW_FOREGROUND_TAB;

browser::Navigate(&p);

}

@@ -208,14 +208,14 @@

const int kTabCount = 4;

// Create kTabCount - 1 tabs since we start with 1 tab already.

for (int i = 0; i < kTabCount - 1; ++i) {

- browser::NavigateParams p(browser(), GURL(), PageTransition::LINK);

+ browser::NavigateParams p(browser(), GURL(), content::PAGE_TRANSITION_LINK);

p.disposition = NEW_FOREGROUND_TAB;

browser::Navigate(&p);

}

EXPECT_EQ(kTabCount, browser()->tab_count());

// Create a popup

- browser::NavigateParams p(browser(), GURL(), PageTransition::LINK);

+ browser::NavigateParams p(browser(), GURL(), content::PAGE_TRANSITION_LINK);

p.disposition = NEW_POPUP;

ui_test_utils::NavigateToURL(&p);