chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm - Issue 8253002: Move PageTransition into content namespace. While I'm touching all these files, I've also updated...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

Issue 8253002: Move PageTransition into content namespace. While I'm touching all these files, I've also updated... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/tab_contents/web_drop_target.mm ('k') | chrome/browser/ui/cocoa/tabs/tab_strip_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

===================================================================

--- chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm (revision 105162)

+++ chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm (working copy)

@@ -1802,7 +1802,8 @@

switch (disposition) {

case NEW_FOREGROUND_TAB: {

UserMetrics::RecordAction(UserMetricsAction("Tab_DropURLBetweenTabs"));

- browser::NavigateParams params(browser_, *url, PageTransition::TYPED);

+ browser::NavigateParams params(

+ browser_, *url, content::PAGE_TRANSITION_TYPED);

params.disposition = disposition;

params.tabstrip_index = index;

params.tabstrip_add_types =

@@ -1814,7 +1815,7 @@

UserMetrics::RecordAction(UserMetricsAction("Tab_DropURLOnTab"));

tabStripModel_->GetTabContentsAt(index)

->tab_contents()->OpenURL(*url, GURL(), CURRENT_TAB,

- PageTransition::TYPED);

+ content::PAGE_TRANSITION_TYPED);

tabStripModel_->ActivateTabAt(index, true);

break;

default: