Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3467)

Unified Diff: chrome/browser/sync/glue/typed_url_change_processor.cc

Issue 8253002: Move PageTransition into content namespace. While I'm touching all these files, I've also updated... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/typed_url_change_processor.cc
===================================================================
--- chrome/browser/sync/glue/typed_url_change_processor.cc (revision 105162)
+++ chrome/browser/sync/glue/typed_url_change_processor.cc (working copy)
@@ -170,8 +170,8 @@
bool TypedUrlChangeProcessor::ShouldSyncVisit(
history::URLVisitedDetails* details) {
int typed_count = details->row.typed_count();
- PageTransition::Type transition = static_cast<PageTransition::Type>(
- details->transition & PageTransition::CORE_MASK);
+ content::PageTransition transition = static_cast<content::PageTransition>(
+ details->transition & content::PAGE_TRANSITION_CORE_MASK);
// Just use an ad-hoc criteria to determine whether to ignore this
// notification. For most users, the distribution of visits is roughly a bell
@@ -180,7 +180,7 @@
// suggestions. But there are relatively few URLs with > 10 visits, and those
// tend to be more broadly distributed such that there's no need to sync up
// every visit to preserve their relative ordering.
- return (transition == PageTransition::TYPED &&
+ return (transition == content::PAGE_TRANSITION_TYPED &&
(typed_count < kTypedUrlVisitThrottleThreshold ||
(typed_count % kTypedUrlVisitThrottleMultiple) == 0));
}
@@ -251,7 +251,7 @@
DCHECK(c == 0 || typed_url.visits(c) > typed_url.visits(c - 1));
added_visits.push_back(history::VisitInfo(
base::Time::FromInternalValue(typed_url.visits(c)),
- typed_url.visit_transitions(c)));
+ content::PageTransitionFromInt(typed_url.visit_transitions(c))));
}
pending_new_visits_.push_back(
« no previous file with comments | « chrome/browser/sync/glue/synced_session_tracker_unittest.cc ('k') | chrome/browser/sync/glue/typed_url_model_associator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698