Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Side by Side Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 8253002: Move PageTransition into content namespace. While I'm touching all these files, I've also updated... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/browser_window_controller.h" 5 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
6 6
7 #include <cmath> 7 #include <cmath>
8 #include <numeric> 8 #include <numeric>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 1727 matching lines...) Expand 10 before | Expand all | Expand 10 after
1738 // Handle the openLearnMoreAboutCrashLink: action from SadTabController when 1738 // Handle the openLearnMoreAboutCrashLink: action from SadTabController when
1739 // "Learn more" link in "Aw snap" page (i.e. crash page or sad tab) is 1739 // "Learn more" link in "Aw snap" page (i.e. crash page or sad tab) is
1740 // clicked. Decoupling the action from its target makes unitestting possible. 1740 // clicked. Decoupling the action from its target makes unitestting possible.
1741 - (void)openLearnMoreAboutCrashLink:(id)sender { 1741 - (void)openLearnMoreAboutCrashLink:(id)sender {
1742 if ([sender isKindOfClass:[SadTabController class]]) { 1742 if ([sender isKindOfClass:[SadTabController class]]) {
1743 SadTabController* sad_tab = static_cast<SadTabController*>(sender); 1743 SadTabController* sad_tab = static_cast<SadTabController*>(sender);
1744 TabContents* tab_contents = [sad_tab tabContents]; 1744 TabContents* tab_contents = [sad_tab tabContents];
1745 if (tab_contents) { 1745 if (tab_contents) {
1746 GURL helpUrl = 1746 GURL helpUrl =
1747 google_util::AppendGoogleLocaleParam(GURL(chrome::kCrashReasonURL)); 1747 google_util::AppendGoogleLocaleParam(GURL(chrome::kCrashReasonURL));
1748 tab_contents->OpenURL(helpUrl, GURL(), CURRENT_TAB, PageTransition::LINK); 1748 tab_contents->OpenURL(
1749 helpUrl, GURL(), CURRENT_TAB, content::PAGE_TRANSITION_LINK);
1749 } 1750 }
1750 } 1751 }
1751 } 1752 }
1752 1753
1753 // Delegate method called when window did move. (See below for why we don't use 1754 // Delegate method called when window did move. (See below for why we don't use
1754 // |-windowWillMove:|, which is called less frequently than |-windowDidMove| 1755 // |-windowWillMove:|, which is called less frequently than |-windowDidMove|
1755 // instead.) 1756 // instead.)
1756 - (void)windowDidMove:(NSNotification*)notification { 1757 - (void)windowDidMove:(NSNotification*)notification {
1757 [self saveWindowPositionIfNeeded]; 1758 [self saveWindowPositionIfNeeded];
1758 1759
(...skipping 374 matching lines...) Expand 10 before | Expand all | Expand 10 after
2133 2134
2134 - (BOOL)supportsBookmarkBar { 2135 - (BOOL)supportsBookmarkBar {
2135 return [self supportsWindowFeature:Browser::FEATURE_BOOKMARKBAR]; 2136 return [self supportsWindowFeature:Browser::FEATURE_BOOKMARKBAR];
2136 } 2137 }
2137 2138
2138 - (BOOL)isTabbedWindow { 2139 - (BOOL)isTabbedWindow {
2139 return browser_->is_type_tabbed(); 2140 return browser_->is_type_tabbed();
2140 } 2141 }
2141 2142
2142 @end // @implementation BrowserWindowController(WindowType) 2143 @end // @implementation BrowserWindowController(WindowType)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698